linux-kernel - Re: [PATCH net-next v12 4/5] riscv: dts: spacemit: Add Ethernet support for BPI-F3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <007c08ab-b432-463f-abd8-215371e117c4@iscas.ac.cn>
Date: Sun, 14 Sep 2025 12:31:04 +0800
From: Vivian Wang <wangruikang@...as.ac.cn>
To: Andrew Lunn <andrew@...n.ch>
Cc: Vivian Wang <uwu@...m.page>, Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
 Junhui Liu <junhui.liu@...moral.tech>, Simon Horman <horms@...nel.org>,
 Maxime Chevallier <maxime.chevallier@...tlin.com>, netdev@...r.kernel.org,
 devicetree@...r.kernel.org, linux-riscv@...ts.infradead.org,
 spacemit@...ts.linux.dev, linux-kernel@...r.kernel.org,
 Hendrik Hamerlinck <hendrik.hamerlinck@...mernet.be>,
 Andrew Lunn <andrew+netdev@...n.ch>, Jakub Kicinski <kuba@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Yixun Lan <dlan@...too.org>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>, Philipp Zabel <p.zabel@...gutronix.de>,
 Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt
 <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
 Alexandre Ghiti <alex@...ti.fr>
Subject: Re: [PATCH net-next v12 4/5] riscv: dts: spacemit: Add Ethernet
 support for BPI-F3

On 9/14/25 12:23, Vivian Wang wrote:
> Banana Pi BPI-F3 uses an RGMII PHY for each port and uses GPIO for PHY
> reset.
>
> Tested-by: Hendrik Hamerlinck <hendrik.hamerlinck@...mernet.be>
> Signed-off-by: Vivian Wang <wangruikang@...as.ac.cn>
> Reviewed-by: Yixun Lan <dlan@...too.org>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> ---
>  arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts | 48 +++++++++++++++++++++++++
>  1 file changed, 48 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
> index fe22c747c5012fe56d42ac8a7efdbbdb694f31b6..33e223cefd4bd3a12fae176ac6cddd8276cb53dc 100644
> --- a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
> +++ b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
> @@ -11,6 +11,8 @@ / {
>  	compatible = "bananapi,bpi-f3", "spacemit,k1";
>  
>  	aliases {
> +		ethernet0 = &eth0;
> +		ethernet1 = &eth1;

Hi Andrew,

I added these two aliases in v12, but kept your Reviewed-by for v11
because this is fairly trivial. Same for patch 5.

Is this okay?

Thanks,
Vivian "dramforever" Wang