[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20250914181823.a17382ac3a039dc4a8257578@kernel.org>
Date: Sun, 14 Sep 2025 18:18:23 +0900
From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
To: Johannes Thumshirn <johannes.thumshirn@....com>
Cc: Jens Axboe <axboe@...nel.dk>, Steven Rostedt <rostedt@...dmis.org>,
Masami Hiramatsu <mhiramat@...nel.org>, Mathieu Desnoyers
<mathieu.desnoyers@...icios.com>, linux-block@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org,
linux-btrace@...r.kernel.org, John Garry <john.g.garry@...cle.com>, Hannes
Reinecke <hare@...e.de>, Damien Le Moal <dlemoal@...nel.org>, Christoph
Hellwig <hch@....de>, Naohiro Aota <naohiro.aota@....com>, Shinichiro
Kawasaki <shinichiro.kawasaki@....com>, Chaitanya Kulkarni
<chaitanyak@...dia.com>, "Martin K . Petersen" <martin.petersen@...cle.com>
Subject: Re: [PATCH 00/21] blktrace: Add user-space support for zoned
command tracing
Hi Johannes,
On Tue, 9 Sep 2025 13:07:02 +0200
Johannes Thumshirn <johannes.thumshirn@....com> wrote:
> This patch series extends the user-space blktrace tools to support the new
> trace events for zoned block device commands introduced in the corresponding
> kernel patch series.
I guess this series are patches against for user-space blktrace tool
https://git.kernel.dk/?p=blktrace.git
And the updates depends on the kernel side update of your series;
https://lore.kernel.org/all/20250909110611.75559-1-johannes.thumshirn@wdc.com/
Right?
I'm not sure how the blktrace tool development is managed, but please make
sure this series is not for the kernel. (ah, both has blktrace: tag, hmmm)
Thank you,
>
> The updates include:
>
> - Introduction of a new ioctl requesting the v2 version of the trace
> - Definitions for new zoned operation trace events.
> - Parsing support in blkparse for these events.
> - Display of the new events with clear labeling (e.g., ZO, ZA, ZR).
> - Backward-compatible changes that do not affect existing functionality.
>
> These changes complement the kernel patches and allow full visibility into
> zone management commands in blktrace output, enabling better analysis and
> debugging of zoned storage workloads.
>
> The updated blktrace utility will first issue the BLKTRACESETUP2 ioctl and if
> it fails transpartently fall back to BLKTRACESETUP allowing backwards
> compatibility.
>
> Feedback and testing on additional device types are appreciated.
>
> Johannes Thumshirn (21):
> fix comment for struct blk_trace_setup:
> add definitions for BLKTRACESETUP2
> call BLKTRACESETUP2 ioctl per default to setup a trace
> blktrace: change size of action to 64 bits
> blktrace: add definitions for blk_io_trace2
> blktrace: support protocol version 8
> blkparse: pass magic to get_magic
> blkparse: read 'magic' first
> blkparse: factor out reading of a singe blk_io_trace event
> blkparse: skip unsupported protocol versions
> blkparse: make get_pdulen() take the pdu_len
> blkiomon: read 'magic' first
> blktrace: pass magic to CHECK_MAGIC macro
> blktrace: pass magic to verify_trace
> blktrace: rename trace_to_cpu to bit_trace_to_cpu
> blkparse: use blk_io_trace2 internally
> blkparse: natively parse blk_io_trace2
> blkparse: parse zone (un)plug actions
> blkparse: add zoned commands to fill_rwbs()
> blkparse: parse zone management commands
> blkparse: parse zone append completions
>
> act_mask.c | 4 +-
> blkiomon.c | 15 +-
> blkparse.c | 450 ++++++++++++++++++++++++++++++++++---------------
> blkparse_fmt.c | 105 +++++++++---
> blkrawverify.c | 14 +-
> blktrace.c | 40 ++++-
> blktrace.h | 64 +++++--
> blktrace_api.h | 54 +++++-
> 8 files changed, 560 insertions(+), 186 deletions(-)
>
> --
> 2.51.0
>
--
Masami Hiramatsu (Google) <mhiramat@...nel.org>
Powered by blists - more mailing lists