linux-kernel - Re: [RFC PATCH 1/4] dt-bindings: riscv: Add trace components description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250915023915.630-1-cp0613@linux.alibaba.com>
Date: Mon, 15 Sep 2025 10:39:15 +0800
From: cp0613@...ux.alibaba.com
To: krzk@...nel.org
Cc: alex@...ti.fr,
	aou@...s.berkeley.edu,
	cp0613@...ux.alibaba.com,
	guoren@...nel.org,
	linux-kernel@...r.kernel.org,
	linux-riscv@...ts.infradead.org,
	palmer@...belt.com,
	paul.walmsley@...ive.com
Subject: Re: [RFC PATCH 1/4] dt-bindings: riscv: Add trace components description

On Thu, 11 Sep 2025 19:24:39 +0200, krzk@...nel.org wrote:

> > This patch has added property definitions related to the riscv> 

> Please do not use "This commit/patch/change", but imperative mood. See
> longer explanation here:
> https://elixir.bootlin.com/linux/v6.16/source/Documentation/process/submitting-patches.rst#L94> 

> <form letter>
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC. It might happen, that command when run on an older
> kernel, gives you outdated entries. Therefore please be sure you base
> your patches on recent Linux kernel.> 

> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
> people, so fix your workflow. Tools might also fail if you work on some
> ancient tree (don't, instead use mainline) or work on fork of kernel
> (don't, instead use mainline). Just use b4 and everything should be
> fine, although remember about `b4 prep --auto-to-cc` if you added new
> patches to the patchset.> 

> You missed at least devicetree list (maybe more), so this won't be
> tested by automated tooling. Performing review on untested code might be
> a waste of time.> 

> Please kindly resend and include all necessary To/Cc entries.
> </form letter>> 
> 

> > trace component, providing a foundation for subsequent driver
> > implementations.

Thank you very much for your review.
My next resend will include all necessary To/Cc entries.


>> +    items:
>> +      - const: riscv_trace,funnel-controller>

>You need to start following DTS coding style.>
>
>

>> +  reg:
>> +    description: A memory region containing registers for funnel controller

Indeed, the current dt-bindings are very primitive and may contain some
errors. I should improve and check them before sending them out. I will
pay attention to it next time.

Thank you,
Pei