linux-kernel - Re: [PATCH] drm/xe: Fix a NULL vs IS_ERR() in xe_vm_add_compute_exec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aMgHxkTeXQuXkhC8@intel.com>
Date: Mon, 15 Sep 2025 08:34:14 -0400
From: Rodrigo Vivi <rodrigo.vivi@...el.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
CC: Matthew Brost <matthew.brost@...el.com>, Lucas De Marchi
	<lucas.demarchi@...el.com>, Thomas Hellström
	<thomas.hellstrom@...ux.intel.com>, David Airlie <airlied@...il.com>, "Simona
 Vetter" <simona@...ll.ch>, <intel-xe@...ts.freedesktop.org>,
	<dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>,
	<kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] drm/xe: Fix a NULL vs IS_ERR() in
 xe_vm_add_compute_exec_queue()

On Mon, Sep 15, 2025 at 02:12:00PM +0300, Dan Carpenter wrote:
> Ping?

Sorry for the delay and thank you for the patch.
pushed to drm-xe-next

> 
> regards,
> dan carpenter
> 
> On Thu, Aug 07, 2025 at 06:53:41PM +0300, Dan Carpenter wrote:
> > The xe_preempt_fence_create() function returns error pointers.  It
> > never returns NULL.  Update the error checking to match.
> > 
> > Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
> > Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> > ---
> >  drivers/gpu/drm/xe/xe_vm.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> > index 432ea325677d..5c58c6d99dce 100644
> > --- a/drivers/gpu/drm/xe/xe_vm.c
> > +++ b/drivers/gpu/drm/xe/xe_vm.c
> > @@ -240,8 +240,8 @@ int xe_vm_add_compute_exec_queue(struct xe_vm *vm, struct xe_exec_queue *q)
> >  
> >  	pfence = xe_preempt_fence_create(q, q->lr.context,
> >  					 ++q->lr.seqno);
> > -	if (!pfence) {
> > -		err = -ENOMEM;
> > +	if (IS_ERR(pfence)) {
> > +		err = PTR_ERR(pfence);
> >  		goto out_fini;
> >  	}
> >  
> > -- 
> > 2.47.2