linux-kernel - Re: [PATCH v2 06/11] drm/i915/gt: Use pci_rebar_size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b918053f6ac7b4a27148a1cbf10eb8402572c6c9@intel.com>
Date: Mon, 15 Sep 2025 15:42:23 +0300
From: Jani Nikula <jani.nikula@...ux.intel.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 linux-pci@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>, Krzysztof
 Wilczyński <kw@...ux.com>, Christian König <christian.koenig@....com>,
 Michał Winiarski <michal.winiarski@...el.com>, Alex
 Deucher
 <alexander.deucher@....com>, amd-gfx@...ts.freedesktop.org, David Airlie
 <airlied@...il.com>, dri-devel@...ts.freedesktop.org,
 intel-gfx@...ts.freedesktop.org, intel-xe@...ts.freedesktop.org, Joonas
 Lahtinen <joonas.lahtinen@...ux.intel.com>, Lucas De Marchi
 <lucas.demarchi@...el.com>, Rodrigo Vivi <rodrigo.vivi@...el.com>, Simona
 Vetter <simona@...ll.ch>, Tvrtko Ursulin <tursulin@...ulin.net>,
 ?UTF-8?q?Thomas=20Hellstr=C3=B6m?= <thomas.hellstrom@...ux.intel.com>,
 "Michael J . Ruhl" <mjruhl@...ana.ai>, linux-kernel@...r.kernel.org
Cc: linux-doc@...r.kernel.org, Ilpo Järvinen
 <ilpo.jarvinen@...ux.intel.com>
Subject: Re: [PATCH v2 06/11] drm/i915/gt: Use pci_rebar_size_supported()

On Mon, 15 Sep 2025, Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com> wrote:
> PCI core provides pci_rebar_size_supported() that helps in checking if
> a BAR Size is supported for the BAR or not. Use it in
> i915_resize_lmem_bar() to simplify code.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> Acked-by: Christian König <christian.koenig@....com>

Reviewed-by: Jani Nikula <jani.nikula@...el.com>

and

Acked-by: Jani Nikula <jani.nikula@...el.com>

for merging via whichever tree is convenient.

> ---
>  drivers/gpu/drm/i915/gt/intel_region_lmem.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_region_lmem.c b/drivers/gpu/drm/i915/gt/intel_region_lmem.c
> index 51bb27e10a4f..69c65fc8a72d 100644
> --- a/drivers/gpu/drm/i915/gt/intel_region_lmem.c
> +++ b/drivers/gpu/drm/i915/gt/intel_region_lmem.c
> @@ -61,16 +61,12 @@ static void i915_resize_lmem_bar(struct drm_i915_private *i915, resource_size_t
>  	current_size = roundup_pow_of_two(pci_resource_len(pdev, GEN12_LMEM_BAR));
>  
>  	if (i915->params.lmem_bar_size) {
> -		u32 bar_sizes;
> -
> -		rebar_size = i915->params.lmem_bar_size *
> -			(resource_size_t)SZ_1M;
> -		bar_sizes = pci_rebar_get_possible_sizes(pdev, GEN12_LMEM_BAR);
> -
> +		rebar_size = i915->params.lmem_bar_size * (resource_size_t)SZ_1M;
>  		if (rebar_size == current_size)
>  			return;
>  
> -		if (!(bar_sizes & BIT(pci_rebar_bytes_to_size(rebar_size))) ||
> +		if (!pci_rebar_size_supported(pdev, GEN12_LMEM_BAR,
> +					      pci_rebar_bytes_to_size(rebar_size)) ||
>  		    rebar_size >= roundup_pow_of_two(lmem_size)) {
>  			rebar_size = lmem_size;

-- 
Jani Nikula, Intel