linux-kernel - [bug report] powerpc/fsl_rio: Missing of_node_put() calls in fsl_rio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <80453b77-01ca-4fff-8a5a-deed4203be0f@web.de>
Date: Mon, 15 Sep 2025 14:52:42 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: linuxppc-dev@...ts.ozlabs.org, Kumar Gala <galak@...nel.crashing.org>,
 Alexandre Bounine <alexandre.bounine@....com>,
 Christophe Leroy <christophe.leroy@...roup.eu>,
 Jin Qing <b24347@...escale.com>, Li Yang <leoli@...escale.com>,
 Liu Gang <Gang.Liu@...escale.com>, Madhavan Srinivasan
 <maddy@...ux.ibm.com>, Michael Ellerman <mpe@...erman.id.au>,
 Nicholas Piggin <npiggin@...il.com>
Cc: LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org
Subject: [bug report] powerpc/fsl_rio: Missing of_node_put() calls in
 fsl_rio_setup()

Hello,

Another script for the semantic patch language (Coocinelle software) pointed
details out also according to the implementation of the function “fsl_rio_setup”
for further development considerations.
https://elixir.bootlin.com/linux/v6.17-rc5/source/arch/powerpc/sysdev/fsl_rio.c#L439-L731
https://lore.kernel.org/cocci/504107f9-09eb-47fe-96ea-53e375b17eac@web.de/
https://sympa.inria.fr/sympa/arc/cocci/2025-09/msg00023.html

* I got the impression then that the function “of_node_put” should be called
  in more cases here.

* How do you think about to avoid a bit of duplicate source code
  by another update step?

* Further implementation details can be improved.

Regards,
Markus