linux-kernel - Re: [PATCH v4 5/8] media: v4l2-core: Introduce v4l2-params.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <jhynzoppwi22vnrdzrvqixsbvntsli7sj2vtsxrevtmxluveps@q6yzgvlqmxxb>
Date: Mon, 15 Sep 2025 15:31:58 +0200
From: Jacopo Mondi <jacopo.mondi@...asonboard.com>
To: kernel test robot <lkp@...el.com>
Cc: Jacopo Mondi <jacopo.mondi@...asonboard.com>, 
	Dafna Hirschfeld <dafna@...tmail.com>, Laurent Pinchart <laurent.pinchart@...asonboard.com>, 
	Keke Li <keke.li@...ogic.com>, Mauro Carvalho Chehab <mchehab@...nel.org>, 
	Heiko Stuebner <heiko@...ech.de>, Dan Scally <dan.scally@...asonboard.com>, 
	Sakari Ailus <sakari.ailus@...ux.intel.com>, oe-kbuild-all@...ts.linux.dev, linux-media@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-rockchip@...ts.infradead.org, 
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v4 5/8] media: v4l2-core: Introduce v4l2-params.c

Question for media maintainers...

I'm not sure how I should better handle this one

On Sun, Aug 24, 2025 at 07:16:21AM +0800, kernel test robot wrote:
> Hi Jacopo,
>
> kernel test robot noticed the following build errors:
>
> [auto build test ERROR on a75b8d198c55e9eb5feb6f6e155496305caba2dc]
>
> url:    https://github.com/intel-lab-lkp/linux/commits/Jacopo-Mondi/media-uapi-Introduce-V4L2-extensible-params/20250820-210503
> base:   a75b8d198c55e9eb5feb6f6e155496305caba2dc
> patch link:    https://lore.kernel.org/r/20250820-extensible-parameters-validation-v4-5-30fe5a99cb1f%40ideasonboard.com
> patch subject: [PATCH v4 5/8] media: v4l2-core: Introduce v4l2-params.c
> config: nios2-randconfig-002-20250824 (https://download.01.org/0day-ci/archive/20250824/202508240704.AZwGXBaw-lkp@intel.com/config)
> compiler: nios2-linux-gcc (GCC) 9.5.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250824/202508240704.AZwGXBaw-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202508240704.AZwGXBaw-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
>    nios2-linux-ld: drivers/media/v4l2-core/v4l2-params.o: in function `v4l2_params_buffer_validate':
>    v4l2-params.c:(.text+0x124): undefined reference to `vb2_plane_vaddr'
> >> v4l2-params.c:(.text+0x124): relocation truncated to fit: R_NIOS2_CALL26 against `vb2_plane_vaddr'
>

Clearly v4l2-params.c (now v4l2-isp.c) depends on VIDEOBUF2_CORE

Right now v4l2-params.c gets compiled in as part of the
videodev-objs Makefile target. IOW is not gated by a KConfig option.

To select (or better, depend) on VIDEOBUF2_CORE I should guard
v4l2-params.c with a KConfig option so that I can 'depend on
VIDEOBUF2_CORE'. Drivers that use the v4l2-params.c helper would then
have to 'select V4L2_PARAMS` (or similar).

Is this the best approach or are there alternatives I might be missing ?

> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
>