linux-kernel - Re: [PATCH v1 1/2] ASoC: dt-bindings: cirrus,cs35l41: Document the cirrus,subsystem-id property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5f0db8bb-9eff-4f11-8705-7250fe715b09@opensource.cirrus.com>
Date: Mon, 15 Sep 2025 14:49:12 +0100
From: Stefan Binding <sbinding@...nsource.cirrus.com>
To: Rob Herring <robh@...nel.org>
Cc: Mark Brown <broonie@...nel.org>, Krzysztof Kozlowski
 <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, linux-sound@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        patches@...nsource.cirrus.com
Subject: Re: [PATCH v1 1/2] ASoC: dt-bindings: cirrus,cs35l41: Document the
 cirrus,subsystem-id property


On 12/09/2025 22:41, Rob Herring wrote:
> On Fri, Sep 12, 2025 at 11:45:37AM +0100, Stefan Binding wrote:
>> Add new property: cirrus,subsystem-id
>> This new property is used to uniquely identify the system if device
>> tree is used, to allow the driver to select the correct firmware and
>> tuning for the system.
>>
>> Signed-off-by: Stefan Binding <sbinding@...nsource.cirrus.com>
>> ---
>>  Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml b/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml
>> index 14dea1feefc5..a9eb9bd7ad9c 100644
>> --- a/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml
>> +++ b/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml
>> @@ -151,6 +151,12 @@ properties:
>>      minimum: 0
>>      maximum: 5
>>  
>> +  cirrus,subsystem-id:
>> +    description:
>> +      Subsystem ID. If this property is present, it sets the system name,
>> +      used to identify the firmware and tuning to load.
>> +    type: string
> Why not use standard 'firmware-name' to just say exactly what firmware 
> to load?

The DSP driver searches for a compatible firmware (and tuning) based on what it is able to read from the hardware.
However, the SSID is based on the system, and cannot be read from the hardware, therefore it needs to be read from the Device Tree.
On ACPI-based systems, it is able to read this from the ACPI _SUB property, and to maintain compatibility with the driver between ACPI and Device Tree systems we need an equivalent property.
In addition, the driver actually loads 2 files, firmware and tuning, and the SSID is used to determine the file name of both files.

Thanks,

Stefan

>
> Rob