linux-kernel - Re: [PATCH v2 1/2] tty: serial: 8250

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aMgoi8sQlNhc3CXq@smile.fi.intel.com>
Date: Mon, 15 Sep 2025 17:54:03 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Daniel Golle <daniel@...rotopia.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jirislaby@...nel.org>,
	Matthias Brugger <matthias.bgg@...il.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	Uwe Kleine-König <u.kleine-koenig@...libre.com>,
	Yu Jiaoliang <yujiaoliang@...o.com>,
	Changqi Hu <changqi.hu@...iatek.com>,
	Sam Shih <sam.shih@...iatek.com>,
	Steven Liu <steven.liu@...iatek.com>,
	John Crispin <john@...ozen.org>, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v2 1/2] tty: serial: 8250_mtk: enable baud clock

On Mon, Sep 15, 2025 at 02:06:37PM +0100, Daniel Golle wrote:

...

> -		data->uart_clk = devm_clk_get(&pdev->dev, NULL);
> +		data->uart_clk = devm_clk_get_enabled(&pdev->dev, NULL);
>  		if (IS_ERR(data->uart_clk)) {
>  			dev_warn(&pdev->dev, "Can't get uart clock\n");
>  			return PTR_ERR(data->uart_clk);

Consider making this to be either dev_warn_once() / _ratelimited() or
better to have

	return dev_err_probe(...);

This will allow to avoid flooding the logs when clock is not yet ready.
The proposed change can be done in the separate patch.

-- 
With Best Regards,
Andy Shevchenko