linux-kernel - Re: [PATCH v2] r8169: enable ASPM on Dell platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202509151143.M8cTV3NE-lkp@intel.com>
Date: Mon, 15 Sep 2025 11:46:50 +0800
From: kernel test robot <lkp@...el.com>
To: "Chia-Lin Kao (AceLan)" <acelan.kao@...onical.com>,
	Heiner Kallweit <hkallweit1@...il.com>, nic_swsd@...ltek.com,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	linux-kernel@...r.kernel.org, "Wang, Crag" <Crag.Wang@...l.com>,
	"Chen, Alan" <Alan.Chen6@...l.com>,
	"Alex Shen@...l" <Yijun.Shen@...l.com>
Cc: oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org
Subject: Re: [PATCH v2] r8169: enable ASPM on Dell platforms

Hi Chia-Lin,

kernel test robot noticed the following build warnings:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.17-rc6 next-20250912]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Chia-Lin-Kao-AceLan/r8169-enable-ASPM-on-Dell-platforms/20250915-093648
base:   linus/master
patch link:    https://lore.kernel.org/r/20250915013555.365230-1-acelan.kao%40canonical.com
patch subject: [PATCH v2] r8169: enable ASPM on Dell platforms
config: csky-randconfig-002-20250915 (https://download.01.org/0day-ci/archive/20250915/202509151143.M8cTV3NE-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 15.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250915/202509151143.M8cTV3NE-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509151143.M8cTV3NE-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/net/ethernet/realtek/r8169_main.c:5370:6: warning: no previous prototype for 'rtl_aspm_new_dell_platforms' [-Wmissing-prototypes]
    5370 | bool rtl_aspm_new_dell_platforms(void)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/rtl_aspm_new_dell_platforms +5370 drivers/net/ethernet/realtek/r8169_main.c

  5369	
> 5370	bool rtl_aspm_new_dell_platforms(void)
  5371	{
  5372		const char *family = dmi_get_system_info(DMI_PRODUCT_FAMILY);
  5373		static const char * const dell_product_families[] = {
  5374			"Alienware",
  5375			"Dell Laptops",
  5376			"Dell Pro Laptops",
  5377			"Dell Pro Max Laptops",
  5378			"Dell Desktops",
  5379			"Dell Pro Desktops",
  5380			"Dell Pro Max Desktops",
  5381			"Dell Pro Rugged Laptops"
  5382		};
  5383		int i;
  5384	
  5385		if (!family)
  5386			return false;
  5387	
  5388		for (i = 0; i < ARRAY_SIZE(dell_product_families); i++) {
  5389			if (str_has_prefix(family, dell_product_families[i]))
  5390				return true;
  5391		}
  5392	
  5393		return false;
  5394	}
  5395	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki