linux-kernel - Re: [PATCH v2 00/12] Curve25519 cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250915162044.GD1993@quark>
Date: Mon, 15 Sep 2025 11:20:44 -0500
From: Eric Biggers <ebiggers@...nel.org>
To: linux-crypto@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, Ard Biesheuvel <ardb@...nel.org>,
	"Jason A . Donenfeld" <Jason@...c4.com>,
	Zhiqi Song <songzhiqi1@...wei.com>,
	Longfang Liu <liulongfang@...wei.com>, x86@...nel.org,
	linux-arm-kernel@...ts.infradead.org, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH v2 00/12] Curve25519 cleanup

On Sat, Sep 06, 2025 at 02:35:11PM -0700, Eric Biggers wrote:
> This series is targeting libcrypto-next.  It can also be retrieved from:
> 
>     git fetch https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git curve25519-v2
> 
> This series removes the unused crypto_kpp support for Curve25519,
> migrates curve25519-selftest to a KUnit test suite, and reorganizes the
> generic and arch-optimized Curve25519 code to all be located in
> lib/crypto/ and built into a single libcurve25519 module.
> 
> Changed from v1:
> - Split kpp removal into multiple patches
> - Don't select CRYPTO_LIB_CURVE25519_GENERIC from KUnit test
> - Removed unnecessary parameter from hpre_ecc_clear_ctx()
> - Removed unnecessary 'return' from arm curve25519_base_arch()
> - Updated file comment in lib/crypto/curve25519.c
> - Made kconfig help text for KUnit test more consistent with other tests
> - Used initializer in test_curve25519()
> - Removed unnecessary newlines from messages in test_curve25519()
> - Use NSEC_PER_SEC instead of literal 1000000000
> - Added an Acked-by

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/log/?h=libcrypto-next

Reviews and acks would still be appreciated, of course.

- Eric