linux-kernel - Re: [PATCH] KEYS: encrypted: Use SHA-256 library instead of crypto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250915163949.GF1993@quark>
Date: Mon, 15 Sep 2025 11:39:49 -0500
From: Eric Biggers <ebiggers@...nel.org>
To: Mimi Zohar <zohar@...ux.ibm.com>
Cc: Jarkko Sakkinen <jarkko@...nel.org>, keyrings@...r.kernel.org,
	David Howells <dhowells@...hat.com>,
	linux-integrity@...r.kernel.org, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KEYS: encrypted: Use SHA-256 library instead of
 crypto_shash

On Sun, Sep 07, 2025 at 07:57:12AM -0400, Mimi Zohar wrote:
> On Tue, 2025-08-05 at 16:41 +0300, Jarkko Sakkinen wrote:
> > On Thu, Jul 31, 2025 at 11:47:47AM -0700, Eric Biggers wrote:
> > > Instead of the "sha256" crypto_shash, just use sha256().  Similarly,
> > > instead of the "hmac(sha256)" crypto_shash, just use
> > > hmac_sha256_usingrawkey().  This is simpler and faster.
> > > 
> > > Signed-off-by: Eric Biggers <ebiggers@...nel.org>
> > 
> > Yeah, fully agree.
> > 
> > Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>
> > 
> > David, will you pick this?
> > 
> 
> Do you want this patch being upstreamed with "[PATCH 0/2] Convert lib/digsig.c
> to SHA-1 library" patch set?
> 
> thanks,
> 
> Mimi

If someone could apply this for v6.18, that would be great.  It's
independent of my other patches.  It looks like Mimi has been taking
changes to this file most recently.  If David or Jarkko wants to take it
instead, that's fine too.  As long as someone does it.

- Eric