[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250915170743.106249-1-niklas.soderlund+renesas@ragnatech.se>
Date: Mon, 15 Sep 2025 19:07:31 +0200
From: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
To: Mauro Carvalho Chehab <mchehab@...nel.org>,
Jacopo Mondi <jacopo.mondi@...asonboard.com>,
Laurent Pinchart <laurent.pinchart@...asonboard.com>,
linux-media@...r.kernel.org,
linux-renesas-soc@...r.kernel.org,
linux-kernel@...r.kernel.org
Cc: Niklas Söderlund <niklas.soderlund+renesas@...natech.se>
Subject: [PATCH v2 00/12] media: Add support for R-Car ISP using Dreamchip RPPX1 ISP
Hello,
This series adds support for two different devices that together enable
ISP support on Renesas R-Car Gen4 ISP processing. The first driver added
is for Dreamchip RPPX1 ISP, this device purely deals with image
processing algorithms, statistics and image conversion; but have no DMA
engines. The second driver is for the R-Car ISP CORE, this device
deals with DMA to/from the RPPX1 ISP and provides a V4L2 user-space
interface for the ISP.
The R-Car ISP driver uses the RPPX1 framework to drive the ISP and
together the two devices provide a functional ISP. For detailed
description of the RPPX1 see patch 1/12, and for details about the R-Car
ISP see commit message in patch 2/12.
The RPPX1 ISP is similar to functionality and design to the Rk1ISP
already supported upstream. For this reason this series reuses the pixel
format for ISP parameters (RK1E) and statistics (RK1S) as the user-space
ABI to configure the ISP. The primary difference to Rk1iSP is the over
all pipeline design and the register layout out is different enough to
make it impractical to bolt it on the existing drivers.
However on a functional block level the blocks amiable and their
register layout mapped to the buffer formats are similar enough to make
the reuse practical. Another difference is that RPPX1 operates at a
hight bitdepth then Rk1ISP, but this is easily supported by scaling the
values to/from the buffers.
All functional blocks present on the RPPX1 are not yet added to the
driver, but most are. Hence not all configuration blocks of the Rk1E
extensible format are supported, but most if not all can be added.
A libcamera pipeline reusing the Rk1ISP IPA have been posted [1] and it
can exercise all function block enabled by this series. It produce good
images using all algorithms available.
Patch 1/12 adds the foundation for the RPPX1 framework. It deals with
probing all function blocks making sure every blocks version register is
supported and setup a "passthru" pipeline that just debayer RAW images.
Patch 2/12 integrates the adds the R-Car ISP CORE DMA parts and
integrates with the RPPX1 framework added in patch 1/12.
Patches 3/12 to 12/12 extends the RPPX1 framewok with the logic to drive
the different IPS modules.
The sum of the work pass v4l2-compliance. A test suite for the enabled
function blocks exists and pass. The work have also been tested with
various libcamera utilities and compliance tests together with a IMX219
and IMX462 sensor on R-Car V4H.
Biggest change from v1 is that more function blocks have been enabled,
and some small bugs found and fixed. See individual patches for
changelog.
Niklas Söderlund (12):
media: rppx1: Add framework to support Dreamchip RPPX1 ISP
media: rcar-isp: Add support for ISPCORE
media: rppx1: Add support for AWB measurement parameters and
statistics
media: rppx1: Add support for AWB gain settings
media: rppx1: Add support for Auto Exposure Measurement
media: rppx1: Add support for Histogram Measurement
media: rppx1: Add support for Black Level Subtraction
media: rppx1: Add support for Color Correction Matrix
media: rppx1: Add support for Lens Shade Correction
media: rppx1: Add support for Gamma Correction
media: rppx1: Add support for Bayer Demosaicing
media: rppx1: Add support for Bilateral Denoising
MAINTAINERS | 6 +
drivers/media/platform/Kconfig | 1 +
drivers/media/platform/Makefile | 1 +
drivers/media/platform/dreamchip/Kconfig | 3 +
drivers/media/platform/dreamchip/Makefile | 6 +
.../media/platform/dreamchip/rppx1/Kconfig | 11 +
.../media/platform/dreamchip/rppx1/Makefile | 33 +
.../platform/dreamchip/rppx1/rpp_module.c | 40 +
.../platform/dreamchip/rppx1/rpp_module.h | 157 +++
.../platform/dreamchip/rppx1/rpp_params.c | 80 ++
.../platform/dreamchip/rppx1/rpp_stats.c | 30 +
.../media/platform/dreamchip/rppx1/rppx1.c | 337 ++++++
.../media/platform/dreamchip/rppx1/rppx1.h | 99 ++
.../platform/dreamchip/rppx1/rppx1_acq.c | 147 +++
.../platform/dreamchip/rppx1/rppx1_awbg.c | 67 ++
.../media/platform/dreamchip/rppx1/rppx1_bd.c | 210 ++++
.../platform/dreamchip/rppx1/rppx1_bdrgb.c | 80 ++
.../platform/dreamchip/rppx1/rppx1_bls.c | 175 +++
.../platform/dreamchip/rppx1/rppx1_cac.c | 29 +
.../platform/dreamchip/rppx1/rppx1_ccor.c | 180 +++
.../media/platform/dreamchip/rppx1/rppx1_db.c | 156 +++
.../platform/dreamchip/rppx1/rppx1_dpcc.c | 76 ++
.../platform/dreamchip/rppx1/rppx1_exm.c | 140 +++
.../media/platform/dreamchip/rppx1/rppx1_ga.c | 83 ++
.../platform/dreamchip/rppx1/rppx1_hist.c | 249 ++++
.../platform/dreamchip/rppx1/rppx1_hist256.c | 46 +
.../media/platform/dreamchip/rppx1/rppx1_is.c | 42 +
.../platform/dreamchip/rppx1/rppx1_lin.c | 60 +
.../platform/dreamchip/rppx1/rppx1_lsc.c | 194 +++
.../platform/dreamchip/rppx1/rppx1_ltm.c | 48 +
.../platform/dreamchip/rppx1/rppx1_ltmmeas.c | 41 +
.../platform/dreamchip/rppx1/rppx1_outif.c | 45 +
.../platform/dreamchip/rppx1/rppx1_outregs.c | 75 ++
.../platform/dreamchip/rppx1/rppx1_rmap.c | 64 +
.../platform/dreamchip/rppx1/rppx1_rmapmeas.c | 47 +
.../platform/dreamchip/rppx1/rppx1_shrp.c | 64 +
.../platform/dreamchip/rppx1/rppx1_wbmeas.c | 188 +++
.../platform/dreamchip/rppx1/rppx1_xyz2luv.c | 26 +
.../media/platform/renesas/rcar-isp/Kconfig | 1 +
.../media/platform/renesas/rcar-isp/Makefile | 2 +-
.../media/platform/renesas/rcar-isp/core-io.c | 1053 +++++++++++++++++
.../media/platform/renesas/rcar-isp/core.c | 790 +++++++++++++
.../media/platform/renesas/rcar-isp/csisp.c | 48 +-
.../platform/renesas/rcar-isp/risp-core.h | 163 +++
include/media/rppx1.h | 33 +
45 files changed, 5418 insertions(+), 8 deletions(-)
create mode 100644 drivers/media/platform/dreamchip/Kconfig
create mode 100644 drivers/media/platform/dreamchip/Makefile
create mode 100644 drivers/media/platform/dreamchip/rppx1/Kconfig
create mode 100644 drivers/media/platform/dreamchip/rppx1/Makefile
create mode 100644 drivers/media/platform/dreamchip/rppx1/rpp_module.c
create mode 100644 drivers/media/platform/dreamchip/rppx1/rpp_module.h
create mode 100644 drivers/media/platform/dreamchip/rppx1/rpp_params.c
create mode 100644 drivers/media/platform/dreamchip/rppx1/rpp_stats.c
create mode 100644 drivers/media/platform/dreamchip/rppx1/rppx1.c
create mode 100644 drivers/media/platform/dreamchip/rppx1/rppx1.h
create mode 100644 drivers/media/platform/dreamchip/rppx1/rppx1_acq.c
create mode 100644 drivers/media/platform/dreamchip/rppx1/rppx1_awbg.c
create mode 100644 drivers/media/platform/dreamchip/rppx1/rppx1_bd.c
create mode 100644 drivers/media/platform/dreamchip/rppx1/rppx1_bdrgb.c
create mode 100644 drivers/media/platform/dreamchip/rppx1/rppx1_bls.c
create mode 100644 drivers/media/platform/dreamchip/rppx1/rppx1_cac.c
create mode 100644 drivers/media/platform/dreamchip/rppx1/rppx1_ccor.c
create mode 100644 drivers/media/platform/dreamchip/rppx1/rppx1_db.c
create mode 100644 drivers/media/platform/dreamchip/rppx1/rppx1_dpcc.c
create mode 100644 drivers/media/platform/dreamchip/rppx1/rppx1_exm.c
create mode 100644 drivers/media/platform/dreamchip/rppx1/rppx1_ga.c
create mode 100644 drivers/media/platform/dreamchip/rppx1/rppx1_hist.c
create mode 100644 drivers/media/platform/dreamchip/rppx1/rppx1_hist256.c
create mode 100644 drivers/media/platform/dreamchip/rppx1/rppx1_is.c
create mode 100644 drivers/media/platform/dreamchip/rppx1/rppx1_lin.c
create mode 100644 drivers/media/platform/dreamchip/rppx1/rppx1_lsc.c
create mode 100644 drivers/media/platform/dreamchip/rppx1/rppx1_ltm.c
create mode 100644 drivers/media/platform/dreamchip/rppx1/rppx1_ltmmeas.c
create mode 100644 drivers/media/platform/dreamchip/rppx1/rppx1_outif.c
create mode 100644 drivers/media/platform/dreamchip/rppx1/rppx1_outregs.c
create mode 100644 drivers/media/platform/dreamchip/rppx1/rppx1_rmap.c
create mode 100644 drivers/media/platform/dreamchip/rppx1/rppx1_rmapmeas.c
create mode 100644 drivers/media/platform/dreamchip/rppx1/rppx1_shrp.c
create mode 100644 drivers/media/platform/dreamchip/rppx1/rppx1_wbmeas.c
create mode 100644 drivers/media/platform/dreamchip/rppx1/rppx1_xyz2luv.c
create mode 100644 drivers/media/platform/renesas/rcar-isp/core-io.c
create mode 100644 drivers/media/platform/renesas/rcar-isp/core.c
create mode 100644 drivers/media/platform/renesas/rcar-isp/risp-core.h
create mode 100644 include/media/rppx1.h
--
2.51.0
Powered by blists - more mailing lists