linux-kernel - Re: [PATCH 1/4] dt-bindings: usb: uhci: Add reset property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250915-fifteen-sappy-82f26231843a@spud>
Date: Mon, 15 Sep 2025 18:36:15 +0100
From: Conor Dooley <conor@...nel.org>
To: Ryan Chen <ryan_chen@...eedtech.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Alan Stern <stern@...land.harvard.edu>,
	Philipp Zabel <p.zabel@...gutronix.de>, linux-usb@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: usb: uhci: Add reset property

On Mon, Sep 15, 2025 at 03:39:23PM +0800, Ryan Chen wrote:
> The UHCI controller on Aspeed SoCs (including AST2700) requires
> its reset line to be deasserted before the controller can be used.
> Add an optional "resets" property to the UHCI device tree bindings
> to describe the phandle to the reset controller.

Looks like the property is not optional at all for your aspeed devices,
and you should require it for those compatibles.

> 
> This property is optional for platforms which do not require
> explicit reset handling.
> 
> Signed-off-by: Ryan Chen <ryan_chen@...eedtech.com>
> ---
>  Documentation/devicetree/bindings/usb/usb-uhci.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/usb-uhci.yaml b/Documentation/devicetree/bindings/usb/usb-uhci.yaml
> index d8336f72dc1f..b1f2b9bd7921 100644
> --- a/Documentation/devicetree/bindings/usb/usb-uhci.yaml
> +++ b/Documentation/devicetree/bindings/usb/usb-uhci.yaml
> @@ -28,6 +28,9 @@ properties:
>    interrupts:
>      maxItems: 1
>  
> +  resets:
> +    maxItems: 1
> +
>    '#ports':
>      $ref: /schemas/types.yaml#/definitions/uint32
>  
> -- 
> 2.34.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)