linux-kernel - Re: [PATCH v3 1/3] dt-bindings: thermal: samsung: Add a hw-sensor-indices property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b453e64b-b3db-4b8f-ba9d-0da7e55fe057@kernel.org>
Date: Mon, 15 Sep 2025 06:28:38 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Shin Son <shin.son@...sung.com>,
 Bartlomiej Zolnierkiewicz <bzolnier@...il.com>,
 "Rafael J . Wysocki" <rafael@...nel.org>,
 Daniel Lezcano <daniel.lezcano@...aro.org>, Zhang Rui <rui.zhang@...el.com>,
 Lukasz Luba <lukasz.luba@....com>, Rob Herring <robh@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Alim Akhtar <alim.akhtar@...sung.com>,
 Henrik Grimler <henrik@...mler.se>
Cc: linux-pm@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: thermal: samsung: Add a
 hw-sensor-indices property

On 15/09/2025 06:07, Shin Son wrote:
> The exynosautov920 TMU requires per-sensor interrupt enablement
> for its critical trip points.
> 
> - **samsung,hw-sensor-indices**: List of sensor indices physically
>                                  monitored by this TMU block.
> 				 Indicies not listed exist in the SoC
> 				 register map but are not part of
> 				 this TMU instance

Not much improved here. Same comment as before. That's not even correct
syntax but some oddly formatted code. I asked to drop it and instead
describe hardware. This is not a place to write some **code** or
whatever this paragraph is about to represent.

> 
> Additionally, add myself to the bindings' maintainers list, as I plan
> to actively work on the exynosautov920 TMU support and handle further
> updates in this area.
> I also restrict 'samsung,hw-sensor-indices' to the V920 variant. To
> ensure properties introduced in 'if/then' blocks are recognized, I
> replace 'addtionalProperties: false' with 'unevaluatedProperties: false'.

No, don't do that.

> 
> Signed-off-by: Shin Son <shin.son@...sung.com>
> ---
>  .../thermal/samsung,exynos-thermal.yaml       | 40 ++++++++++++++++++-
>  1 file changed, 38 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml b/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml
> index 29a08b0729ee..448c68986b10 100644
> --- a/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml
> +++ b/Documentation/devicetree/bindings/thermal/samsung,exynos-thermal.yaml
> @@ -8,6 +8,7 @@ title: Samsung Exynos SoC Thermal Management Unit (TMU)
>  
>  maintainers:
>    - Krzysztof Kozlowski <krzk@...nel.org>
> +  - Shin Son <shin.son@...sung.com>
>  
>  description: |
>    For multi-instance tmu each instance should have an alias correctly numbered
> @@ -27,6 +28,7 @@ properties:
>        - samsung,exynos5420-tmu-ext-triminfo
>        - samsung,exynos5433-tmu
>        - samsung,exynos7-tmu
> +      - samsung,exynosautov920-tmu
>  
>    clocks:
>      minItems: 1
> @@ -62,7 +64,7 @@ properties:
>      minItems: 1
>  
>    '#thermal-sensor-cells':
> -    const: 0
> +    enum: [0, 1]
>  
>    vtmu-supply:
>      description: The regulator node supplying voltage to TMU.
> @@ -97,6 +99,8 @@ allOf:
>          reg:
>            minItems: 2
>            maxItems: 2
> +        '#thermal-sensor-cells':
> +          const: 0
>    - if:
>        properties:
>          compatible:
> @@ -119,6 +123,8 @@ allOf:
>          reg:
>            minItems: 1
>            maxItems: 1
> +        '#thermal-sensor-cells':
> +          const: 0
>  
>    - if:
>        properties:
> @@ -139,8 +145,38 @@ allOf:
>          reg:
>            minItems: 1
>            maxItems: 1
> +        '#thermal-sensor-cells':
> +          const: 0
>  
> -additionalProperties: false
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: samsung,exynosautov920-tmu
> +    then:
> +      properties:
> +        clocks:
> +          minItems: 1
> +          maxItems: 1
> +        reg:
> +          minItems: 1
> +          maxItems: 1
> +        '#thermal-sensor-cells':
> +          const: 1
> +        samsung,hw-sensor-indices:
> +          description:
> +            List of thermal sensor indices physically monitored by this TMU instance.
> +            Indices not listed correspond to registers that exist in the SoC
> +            but are not connected to this TMU hardware block.
> +          $ref: /schemas/types.yaml#/definitions/uint32-array

I don't understand what is happening here with this binding. See writing
schema and example-schema.



Best regards,
Krzysztof