linux-kernel - Re: [PATCH net-next] net: wan: framer: Add version sysfs attribute for the Lantiq PEF2256 framer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250915184612.GU224143@horms.kernel.org>
Date: Mon, 15 Sep 2025 19:46:12 +0100
From: Simon Horman <horms@...nel.org>
To: Christophe Leroy <christophe.leroy@...roup.eu>
Cc: TRINH THAI Florent <florent.trinh-thai@...soprasteria.com>,
	CASAUBON Jean Michel <jean-michel.casaubon@...soprasteria.com>,
	Herve Codina <herve.codina@...tlin.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: wan: framer: Add version sysfs attribute
 for the Lantiq PEF2256 framer

On Sat, Sep 13, 2025 at 11:13:26AM +0200, Christophe Leroy wrote:
> Lantiq PEF2256 framer has some little differences in behaviour
> depending on its version.
> 
> Add a sysfs attribute to allow user applications to know the
> version.
> 
> Signed-off-by: Christophe Leroy <christophe.leroy@...roup.eu>

...

> @@ -114,6 +115,14 @@ enum pef2256_version pef2256_get_version(struct pef2256 *pef2256)
>  }
>  EXPORT_SYMBOL_GPL(pef2256_get_version);
>  
> +static ssize_t version_show(struct device *dev, struct device_attribute *attr, char *buf)
> +{
> +	struct pef2256 *pef2256 = dev_get_drvdata(dev);
> +
> +	return sysfs_emit(buf, "%s\n", pef2256->version_txt);
> +}
> +DEVICE_ATTR_RO(version);

Hi Christophe,

I think this can be: static DEVICE_ATTR_RO(version);

Flagged by Sparse.

> +
>  enum pef2256_gcm_config_item {
>  	PEF2256_GCM_CONFIG_1544000 = 0,
>  	PEF2256_GCM_CONFIG_2048000,

...