linux-kernel - Re: [External] : Re: [PATCH] PCI: plda: Remove the use of dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1f96e533-4863-4085-9da0-99053e0e5901@oracle.com>
Date: Tue, 16 Sep 2025 00:40:57 +0530
From: ALOK TIWARI <alok.a.tiwari@...cle.com>
To: Manivannan Sadhasivam <mani@...nel.org>
Cc: daire.mcnamara@...rochip.com, lpieralisi@...nel.org,
        kwilczynski@...nel.org, bhelgaas@...gle.com, robh@...nel.org,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        Xichao Zhao <zhao.xichao@...o.com>
Subject: Re: [External] : Re: [PATCH] PCI: plda: Remove the use of
 dev_err_probe()



On 9/15/2025 7:37 PM, Manivannan Sadhasivam wrote:
>>> Change is fine as it is. But I think devm_pci_alloc_host_bridge() should return
>>> the actual error pointer instead of NULL and let the callers guess the errno.
>>>
>>> Callers are using both -ENOMEM and -ENODEV, both of then will mask the actual
>>> errno that caused the failure.
>>>
>>> Cleanup task for someone interested 🙂
>>>
>>> - Mani
>> Did you really intend to do that,
> No, I don't have bandwidth right now.
> 
>> Should that be an RFC (for cleanup task) patch ?

I am planning to send a patch for this cleanup.
It will touch all files under drivers/pci/controller/,
and I hope it will be useful.

Thanks,
Alok