linux-kernel - Re: [PATCH mlx5-next 3/3] net/mlx5e: Prevent WQE metadata conflicts between timestamping and offloads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250915191442.GB322881@horms.kernel.org>
Date: Mon, 15 Sep 2025 20:14:42 +0100
From: Simon Horman <horms@...nel.org>
To: Tariq Toukan <tariqt@...dia.com>
Cc: Saeed Mahameed <saeedm@...dia.com>, Leon Romanovsky <leon@...nel.org>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Mark Bloch <mbloch@...dia.com>,
	Sabrina Dubroca <sd@...asysnail.net>, netdev@...r.kernel.org,
	linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
	Gal Pressman <gal@...dia.com>, Dragos Tatulea <dtatulea@...dia.com>,
	Carolina Jubran <cjubran@...dia.com>,
	Jianbo Liu <jianbol@...dia.com>
Subject: Re: [PATCH mlx5-next 3/3] net/mlx5e: Prevent WQE metadata conflicts
 between timestamping and offloads

On Thu, Sep 11, 2025 at 10:10:19AM +0300, Tariq Toukan wrote:
> From: Carolina Jubran <cjubran@...dia.com>
> 
> Update the WQE metadata assignment to avoid overriding existing
> metadata when setting the sysport timestamp ID. Since timestamp IDs are
> limited to 256 values, they use only the lower 8 bits of the metadata
> field.
> 
> To avoid conflicts, move IPsec and MACsec metadata ID to bits 8 and 9,
> and shift the MACsec fs_id accordingly. This ensures safe coexistence
> of timestamping and offload features that use the same metadata field.
> 
> Signed-off-by: Carolina Jubran <cjubran@...dia.com>
> Reviewed-by: Jianbo Liu <jianbol@...dia.com>
> Reviewed-by: Patrisious Haddad <phaddad@...dia.com>
> Reviewed-by: Dragos Tatulea <dtatulea@...dia.com>
> Signed-off-by: Tariq Toukan <tariqt@...dia.com>

Reviewed-by: Simon Horman <horms@...nel.org>