linux-kernel - Re: [PATCH 1/2] slab: prevent warnings when slab obj

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <wb63gbfs3x7hyhy6kzkg5ggn4mgngwrumkpvkg4fg2ju7oeg35@2ls4eggjpfqv>
Date: Mon, 15 Sep 2025 13:14:52 -0700
From: Shakeel Butt <shakeel.butt@...ux.dev>
To: Suren Baghdasaryan <surenb@...gle.com>
Cc: vbabka@...e.cz, akpm@...ux-foundation.org, cl@...two.org, 
	rientjes@...gle.com, roman.gushchin@...ux.dev, harry.yoo@...cle.com, 
	alexei.starovoitov@...il.com, usamaarif642@...il.com, 00107082@....com, souravpanda@...gle.com, 
	kent.overstreet@...ux.dev, linux-mm@...ck.org, linux-kernel@...r.kernel.org, 
	stable@...r.kernel.org
Subject: Re: [PATCH 1/2] slab: prevent warnings when slab obj_exts vector
 allocation fails

On Mon, Sep 15, 2025 at 01:09:17PM -0700, Suren Baghdasaryan wrote:
> When object extension vector allocation fails, we set slab->obj_exts to
> OBJEXTS_ALLOC_FAIL to indicate the failure. Later, once the vector is
> successfully allocated, we will use this flag to mark codetag references
> stored in that vector as empty to avoid codetag warnings.
> 
> slab_obj_exts() used to retrieve the slab->obj_exts vector pointer checks
> slab->obj_exts for being either NULL or a pointer with MEMCG_DATA_OBJEXTS
> bit set. However it does not handle the case when slab->obj_exts equals
> OBJEXTS_ALLOC_FAIL. Add the missing condition to avoid extra warning.
> 
> Fixes: 09c46563ff6d ("codetag: debug: introduce OBJEXTS_ALLOC_FAIL to mark failed slab_ext allocations")
> Reported-by: Shakeel Butt <shakeel.butt@...ux.dev>
> Closes: https://lore.kernel.org/all/jftidhymri2af5u3xtcqry3cfu6aqzte3uzlznhlaylgrdztsi@5vpjnzpsemf5/
> Signed-off-by: Suren Baghdasaryan <surenb@...gle.com>
> Cc: stable@...r.kernel.org # v6.10+

Acked-by: Shakeel Butt <shakeel.butt@...ux.dev>