linux-kernel - Re: [PATCH] tpm_tis: Fix incorrect arguments in tpm_tis_probe_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <17914806-345b-4554-8fff-b366c20a45bc@molgen.mpg.de>
Date: Mon, 15 Sep 2025 22:15:03 +0200
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Gunnar Kudrjavets <gunnarku@...zon.com>
Cc: peterhuewe@....de, jarkko@...nel.org, jgg@...pe.ca,
 stefanb@...ux.vnet.ibm.com, christophe.ricard@...il.com,
 linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org,
 Justinien Bouron <jbouron@...zon.com>
Subject: Re: [PATCH] tpm_tis: Fix incorrect arguments in
 tpm_tis_probe_irq_single

Dear Gunnar,


Thank you for your patch.

Am 15.09.25 um 20:20 schrieb Gunnar Kudrjavets:
> The tpm_tis_write8() call specifies arguments in wrong order. Should be
> (data, addr, value) not (data, value, addr). The initial correct order
> was changed during the major refactoring when the code was split.
> 
> Fixes: 41a5e1cf1fe1 ("tpm/tpm_tis: Split tpm_tis driver into a core and TCG TIS compliant phy")

     $ git describe 41a5e1cf1fe1
     v4.7-rc2-83-g41a5e1cf1fe1

Interesting, that this did not cause more havoc.

> Signed-off-by: Gunnar Kudrjavets <gunnarku@...zon.com>
> Reviewed-by: Justinien Bouron <jbouron@...zon.com>
> ---
>   drivers/char/tpm/tpm_tis_core.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c
> index 4b12c4b9da8b..8954a8660ffc 100644
> --- a/drivers/char/tpm/tpm_tis_core.c
> +++ b/drivers/char/tpm/tpm_tis_core.c
> @@ -978,8 +978,8 @@ static int tpm_tis_probe_irq_single(struct tpm_chip *chip, u32 intmask,
>   	 * will call disable_irq which undoes all of the above.
>   	 */
>   	if (!(chip->flags & TPM_CHIP_FLAG_IRQ)) {
> -		tpm_tis_write8(priv, original_int_vec,
> -			       TPM_INT_VECTOR(priv->locality));
> +		tpm_tis_write8(priv, TPM_INT_VECTOR(priv->locality),
> +			       original_int_vec);
>   		rc = -1;
>   	}

Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>


Kind regards,

Paul