linux-kernel - Re: [PATCH RFC 01/13] PCI: Add SNIA SDXI accelerator sub-class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ikhja2sq.fsf@AUSNATLYNCH.amd.com>
Date: Mon, 15 Sep 2025 15:17:25 -0500
From: Nathan Lynch <nathan.lynch@....com>
To: Bjorn Helgaas <helgaas@...nel.org>
CC: Vinod Koul <vkoul@...nel.org>, Wei Huang <wei.huang2@....com>, "Mario
 Limonciello" <mario.limonciello@....com>, Bjorn Helgaas
	<bhelgaas@...gle.com>, <linux-pci@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <dmaengine@...r.kernel.org>
Subject: Re: [PATCH RFC 01/13] PCI: Add SNIA SDXI accelerator sub-class

Bjorn Helgaas <helgaas@...nel.org> writes:
> On Fri, Sep 05, 2025 at 01:48:24PM -0500, Nathan Lynch via B4 Relay wrote:
>> From: Nathan Lynch <nathan.lynch@....com>
>> 
>> This was added to the PCI Code and ID Assignment Specification in
>> revision 1.14 (2021). Refer to 1.19. "Base Class 12h" of that document
>> as well as the "SDXI PCI-Express Device Architecture" chapter of the
>> SDXI specification:
>
> Would prefer if this said:
>
>   Add sub-class code for SNIA Smart Data Accelerator Interface (SDXI).
>   See PCI Code and ID Assignment spec r1.14, sec 1.19.
>
> so the antecedent of "this" is here instead of in the subject and
> "1.19" doesn't get confused with a spec revision.
>
>> """
>>   SDXI functions are expected to be identified through the SDXI class
>>   code.
>>   * SNIA Smart Data Accelerator Interface (SDXI) controller:
>>     * Base Class = 0x12
>>     * Sub Class = 0x01
>>     * Programming Interface = 0x0
>> """
>> 
>> Information about SDXI may be found at the SNIA website:
>> 
>>   https://www.snia.org/sdxi
>
> I don't think the SDXI spec material is really necessary.  The PCI
> Code and ID spec is definitive for class codes.
>
>> Co-developed-by: Wei Huang <wei.huang2@....com>
>> Signed-off-by: Wei Huang <wei.huang2@....com>
>> Signed-off-by: Nathan Lynch <nathan.lynch@....com>
>
> Acked-by: Bjorn Helgaas <bhelgaas@...gle.com>

Thanks Bjorn, I have made the commit message changes you've suggested
and incorporated your ack for this patch.