linux-kernel - Re: [PATCH 1/3] block/genhd: add sysfs knobs for the device frequency PM QoS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <227f36d8-ca89-486f-b39b-c971e08e20c4@acm.org>
Date: Mon, 15 Sep 2025 14:15:25 -0700
From: Bart Van Assche <bvanassche@....org>
To: Wang Jianzheng <wangjianzheng@...o.com>, Jens Axboe <axboe@...nel.dk>,
 Alim Akhtar <alim.akhtar@...sung.com>, Avri Altman <avri.altman@....com>,
 "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
 "Martin K. Petersen" <martin.petersen@...cle.com>,
 "Rafael J. Wysocki" <rafael@...nel.org>, Peter Wang
 <peter.wang@...iatek.com>, Bean Huo <beanhuo@...ron.com>,
 "Bao D. Nguyen" <quic_nguyenb@...cinc.com>,
 Adrian Hunter <adrian.hunter@...el.com>, linux-block@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
 linux-pm@...r.kernel.org
Subject: Re: [PATCH 1/3] block/genhd: add sysfs knobs for the device frequency
 PM QoS

On 9/14/25 4:45 AM, Wang Jianzheng wrote:
>   block/genhd.c          | 23 +++++++++++++++++++++++
>   include/linux/blkdev.h |  2 ++

If  a new sysfs attribute is added then an entry must be added in
Documentation/ABI/ that explains the purpose of the new attribute and
also how to use it.

> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -213,6 +213,8 @@ struct gendisk {
>   	u64 diskseq;
>   	blk_mode_t open_mode;
>   
> +	int dev_freq_timeout;

The name `dev_freq_timeout` is not sufficient to guess the meaning of
the attribute. Please add a comment.

Thanks,

Bart.