linux-kernel - Re: [PATCH v3 10/18] iio: accel: bma220: migrate to regmap API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aMeo64_bXbn1OkcW@lipo>
Date: Mon, 15 Sep 2025 08:49:31 +0300
From: Petre Rodan <petre.rodan@...dimension.ro>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Jonathan Cameron <jic23@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Nuno S?? <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>,
	linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 10/18] iio: accel: bma220: migrate to regmap API


Hello Andy,

On Sun, Sep 14, 2025 at 03:21:30PM +0300, Andy Shevchenko wrote:
> > +#define BMA220_WDT_MASK                                GENMASK(2, 1)
> > +#define BMA220_WDT_OFF                         0x0
> > +#define BMA220_WDT_1MS                         BIT(1)
> > +#define BMA220_WDT_10MS                                GENMASK(1, 0)
> 
> These do not look like bitfields, please use plain numbers (0, 2, 3).

ok.

> I feel like I commented on this previous time and my comment was ignored...

I can't find your comment. got a link?

best regards,
peter

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)