linux-kernel - Re: [PATCH v1 2/5] clk: samsung: clk-pll: Add support for pll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250915072441.GA8224@nxa18884-linux.ap.freescale.net>
Date: Mon, 15 Sep 2025 15:24:41 +0800
From: Peng Fan <peng.fan@....nxp.com>
To: Ivaylo Ivanov <ivo.ivanov.ivanov1@...il.com>
Cc: Krzysztof Kozlowski <krzk@...nel.org>,
	Sylwester Nawrocki <s.nawrocki@...sung.com>,
	Chanwoo Choi <cw00.choi@...sung.com>,
	Alim Akhtar <alim.akhtar@...sung.com>,
	Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	linux-samsung-soc@...r.kernel.org, devicetree@...r.kernel.org,
	linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 2/5] clk: samsung: clk-pll: Add support for pll_141xx

On Sun, Sep 14, 2025 at 03:21:13PM +0300, Ivaylo Ivanov wrote:
>diff --git a/drivers/clk/samsung/clk-pll.c b/drivers/clk/samsung/clk-pll.c
>index e4faf02b6..acb366f14 100644
>--- a/drivers/clk/samsung/clk-pll.c
>+++ b/drivers/clk/samsung/clk-pll.c
>@@ -273,7 +273,7 @@ static int samsung_pll35xx_set_rate(struct clk_hw *hw, unsigned long drate,
> 	}
> 
> 	/* Set PLL lock time. */
>-	if (pll->type == pll_142xx)
>+	if (pll->type == pll_142xx || pll->type == pll_141xx)
> 		writel_relaxed(rate->pdiv * PLL142XX_LOCK_FACTOR,
> 			pll->lock_reg);
> 	else
>@@ -287,6 +287,7 @@ static int samsung_pll35xx_set_rate(struct clk_hw *hw, unsigned long drate,
> 	tmp |= (rate->mdiv << PLL35XX_MDIV_SHIFT) |
> 			(rate->pdiv << PLL35XX_PDIV_SHIFT) |
> 			(rate->sdiv << PLL35XX_SDIV_SHIFT);
>+

Nit: unrelated change.

Regards,
Peng