linux-kernel - Re: [PATCH v2 5/8] media: imx335: Handle runtime PM in leaf functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <175791773319.7481.4286008141874758651@freya>
Date: Mon, 15 Sep 2025 11:58:53 +0530
From: Jai Luthra <jai.luthra@...asonboard.com>
To: Kieran Bingham <kieran.bingham@...asonboard.com>, Mauro Carvalho Chehab <mchehab@...nel.org>, Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org, Tommaso Merciai <tomm.merciai@...il.com>
Subject: Re: [PATCH v2 5/8] media: imx335: Handle runtime PM in leaf functions

Hi Kieran,

Thanks for the review.

Quoting Kieran Bingham (2025-09-11 16:44:45)
> Quoting Jai Luthra (2025-09-11 09:14:21)
> > Simplify .s_stream callback implementation by moving the runtime PM
> > calls to the leaf functions. This patch should not affect any
> > functionality.
> > 
> > Signed-off-by: Jai Luthra <jai.luthra@...asonboard.com>
> 
> Looks reasonable to me and although the stop_streaming function changes
> to no longer return a value - it was previously unused so no functional
> change indeed as far as I can see:

Yeah it was unused before. This anyway gets fixed when switching to streams
API in the last patch of the series.

> 
> Reviewed-by: Kieran Bingham <kieran.bingham@...asonboard.com>
> 
> > ---
> >  drivers/media/i2c/imx335.c | 51 ++++++++++++++++++++--------------------------
> >  1 file changed, 22 insertions(+), 29 deletions(-)
> > 

Thanks,
    Jai