linux-kernel - Re: [PATCH 1/2] dt-bindings: counter: Add binding for NXP PCF85263/PCF85363 stopwatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3e45f28f-bab5-4e3d-b78f-0586cca8363e@kernel.org>
Date: Mon, 15 Sep 2025 09:23:16 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Lakshay Piplani <lakshay.piplani@....com>, wbg@...nel.org,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, devicetree@...r.kernel.org
Cc: vikash.bansal@....com, priyanka.jain@....com,
 shashank.rebbapragada@....com
Subject: Re: [PATCH 1/2] dt-bindings: counter: Add binding for NXP
 PCF85263/PCF85363 stopwatch

On 15/09/2025 09:14, Lakshay Piplani wrote:
> Add a devicetree binding schema for the NXP PCF8263/PCF85363 devices when used in
> stopwatch (counter) mode.
> 
> In this configuration, the device operates as a high resolution stopwatch over I2C,
> counting in centiseconds (1/100th of a second) up to 999,999 hours.

A nit, subject: drop second/last, redundant "binding for". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

> 
> Signed-off-by: Lakshay Piplani <lakshay.piplani@....com>
> ---
>  .../counter/nxp,pcf85363-stopwatch.yaml       | 49 +++++++++++++++++++
>  1 file changed, 49 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/counter/nxp,pcf85363-stopwatch.yaml
> 
> diff --git a/Documentation/devicetree/bindings/counter/nxp,pcf85363-stopwatch.yaml b/Documentation/devicetree/bindings/counter/nxp,pcf85363-stopwatch.yaml
> new file mode 100644
> index 000000000000..5fbb3f22ace4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/counter/nxp,pcf85363-stopwatch.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/counter/nxp,pcf85363-stopwatch.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP PCF85263ATL/PCF85363ATL Stopwatch (counter) mode
> +
> +maintainers:
> +  - Lakshay Piplani <lakshay.piplani@....com>
> +
> +description: |

Drop |

> +  Binding for NXP PCF82563ATL/PCF85363ATL devices when used in the

Drop "Binding for", but describe here hardware.

With these three fixes:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

<form letter>
This is an automated instruction, just in case, because many review tags
are being ignored. If you know the process, just skip it entirely
(please do not feel offended by me posting it here - no bad intentions
intended, no patronizing, I just want to avoid wasted efforts). If you
do not know the process, here is a short explanation:

Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions
of patchset, under or above your Signed-off-by tag, unless patch changed
significantly (e.g. new properties added to the DT bindings). Tag is
"received", when provided in a message replied to you on the mailing
list. Tools like b4 can help here ('b4 trailers -u ...'). However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for tags received on the version they apply.

Full context and explanation:
https://elixir.bootlin.com/linux/v6.15/source/Documentation/process/submitting-patches.rst#L591
</form letter>

Best regards,
Krzysztof