linux-kernel - Re: [PATCH v3 1/3] dt-bindings: max77705: add interrupt-controller node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a3ce0aa6-41d3-4ce8-adff-14c767d7f871@oss.qualcomm.com>
Date: Mon, 15 Sep 2025 09:49:48 +0200
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Dzmitry Sankouski <dsankouski@...il.com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Krzysztof Kozlowski <krzk@...nel.org>, Lee Jones <lee@...nel.org>,
        Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>
Cc: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: max77705: add interrupt-controller
 node

On 9/12/25 6:47 PM, Dzmitry Sankouski wrote:
> Add interrupt-controller node, because it has dedicated interrupt source
> register, to determine which sub device triggered an interrupt.
> 
> Signed-off-by: Dzmitry Sankouski <dsankouski@...il.com>
> ---
>  Documentation/devicetree/bindings/mfd/maxim,max77705.yaml | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/maxim,max77705.yaml b/Documentation/devicetree/bindings/mfd/maxim,max77705.yaml
> index 0ec89f0adc64..d265c8213a08 100644
> --- a/Documentation/devicetree/bindings/mfd/maxim,max77705.yaml
> +++ b/Documentation/devicetree/bindings/mfd/maxim,max77705.yaml
> @@ -26,6 +26,18 @@ properties:
>    interrupts:
>      maxItems: 1
>  
> +  interrupt-controller:
> +    description:
> +      The driver implements an interrupt controller for the sub devices.
> +      The interrupt number mapping is as follows
> +      0 - charger
> +      1 - topsys
> +      2 - fuelgauge
> +      3 - usb type-c management block.

The MFD driver registers one more interrupt, and these don't seem
to be what you say here:

static const struct regmap_irq max77705_topsys_irqs[] = {
        { .mask = MAX77705_SYSTEM_IRQ_BSTEN_INT, },
        { .mask = MAX77705_SYSTEM_IRQ_SYSUVLO_INT, },
        { .mask = MAX77705_SYSTEM_IRQ_SYSOVLO_INT, },
        { .mask = MAX77705_SYSTEM_IRQ_TSHDN_INT, },
        { .mask = MAX77705_SYSTEM_IRQ_TM_INT, },
};

Konrad