linux-kernel - Re: [PATCH 1/9] tools compiler.h: fix _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <231ba0cc-b568-4310-a96d-f899689fbfc9@t-8ch.de>
Date: Mon, 15 Sep 2025 10:39:55 +0200
From: Thomas Weißschuh <linux@...ssschuh.net>
To: Benjamin Berg <benjamin@...solutions.net>
Cc: linux-um@...ts.infradead.org, Willy Tarreau <w@....eu>, 
	linux-kselftest@...r.kernel.org, Arnaldo Carvalho de Melo <acme@...hat.com>, 
	linux-kernel@...r.kernel.org, Tiwei Bie <tiwei.btw@...group.com>, 
	Benjamin Berg <benjamin.berg@...el.com>
Subject: Re: [PATCH 1/9] tools compiler.h: fix __used definition

On 2025-09-15 09:11:07+0200, Benjamin Berg wrote:
> From: Benjamin Berg <benjamin.berg@...el.com>
> 
> The define mapped to __attribute__((__unused__)) instead of using
> __used__.

Can you explain why it is a problem and add that it now matches the
definition in the regular include/linux/compiler.h?

Anyways:

Reviewed-by: Thomas Weißschuh <linux@...ssschuh.net>

> Fixes: e58e871becec ("tools/lib/lockdep: Remove private kernel headers")
> Signed-off-by: Benjamin Berg <benjamin.berg@...el.com>
> ---
>  tools/include/linux/compiler.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/include/linux/compiler.h b/tools/include/linux/compiler.h
> index 33411ca0cc90..b2c40621d441 100644
> --- a/tools/include/linux/compiler.h
> +++ b/tools/include/linux/compiler.h
> @@ -127,7 +127,7 @@
>  #endif
>  
>  #ifndef __used
> -# define __used		__attribute__((__unused__))
> +# define __used		__attribute__((__used__))
>  #endif
>  
>  #ifndef __packed
> -- 
> 2.51.0
>