linux-kernel - Re: next-20250909: selftests/arm64/gcs/basic-gcs.c:390:30: error: use of undeclared identifier 'HWCAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5fe12804-2538-42c5-b5c7-66d36ff947d9@t-8ch.de>
Date: Mon, 15 Sep 2025 11:23:53 +0200
From: Thomas Weißschuh <linux@...ssschuh.net>
To: Mark Brown <broonie@...nel.org>, 
	Naresh Kamboju <naresh.kamboju@...aro.org>
Cc: open list <linux-kernel@...r.kernel.org>, 
	Linux ARM <linux-arm-kernel@...ts.infradead.org>, 
	"open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@...r.kernel.org>, lkft-triage@...ts.linaro.org, 
	Linux Regressions <regressions@...ts.linux.dev>, Catalin Marinas <catalin.marinas@....com>, 
	Will Deacon <will@...nel.org>, Arnd Bergmann <arnd@...db.de>, 
	Dan Carpenter <dan.carpenter@...aro.org>, Anders Roxell <anders.roxell@...aro.org>, 
	Ben Copeland <benjamin.copeland@...aro.org>, Shuah Khan <shuah@...nel.org>
Subject: Re: next-20250909: selftests/arm64/gcs/basic-gcs.c:390:30: error:
 use of undeclared identifier 'HWCAP_GCS'

On 2025-09-12 12:14:00+0100, Mark Brown wrote:
> On Fri, Sep 12, 2025 at 01:07:58PM +0200, Thomas Weißschuh wrote:
> 
> > The Makefile does *not* use -nostdinc, so the nolibc program probably finds the toolchain's glibc asm/hwcap.h.
> > There also doesn't seem to be a static arm64 hwcap header in tools/include in the first place.
> > I am still wondering how this works for the other tests.
> 
> make headers_install puts a copy in usr/include, probably we just need
> to include that in the include path.

Naresh, could you test the patch below?
The other custom $(CC) rules in the gcs directory are also not
respecting $(CFLAGS), but I'll leave these for now.

diff --git a/tools/testing/selftests/arm64/gcs/Makefile b/tools/testing/selftests/arm64/gcs/Makefile
index d2f3497a9..1fbbf0ca1 100644
--- a/tools/testing/selftests/arm64/gcs/Makefile
+++ b/tools/testing/selftests/arm64/gcs/Makefile
@@ -14,11 +14,11 @@ LDLIBS+=-lpthread
 include ../../lib.mk

 $(OUTPUT)/basic-gcs: basic-gcs.c
-       $(CC) -g -fno-asynchronous-unwind-tables -fno-ident -s -Os -nostdlib \
-               -static -include ../../../../include/nolibc/nolibc.h \
+       $(CC) $(CFLAGS) -fno-asynchronous-unwind-tables -fno-ident -s -nostdlib -nostdinc \
+               -static -I../../../../include/nolibc -include ../../../../include/nolibc/nolibc.h \
                -I../../../../../usr/include \
                -std=gnu99 -I../.. -g \
-               -ffreestanding -Wall $^ -o $@ -lgcc
+               -ffreestanding $^ -o $@ -lgcc

 $(OUTPUT)/gcs-stress-thread: gcs-stress-thread.S
        $(CC) -nostdlib $^ -o $@