linux-kernel - Re: [PATCH v2 3/3] media: imx-mipi-csis: Get number of active lanes via mbus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <175792837500.11401.10747878334767148751@isaac-ThinkPad-T16-Gen-2>
Date: Mon, 15 Sep 2025 10:26:15 +0100
From: Isaac Scott <isaac.scott@...asonboard.com>
To: Frank Li <Frank.li@....com>
Cc: laurent.pinchart@...asonboard.com, rmfrfs@...il.com, martink@...teo.de, kernel@...i.sm, mchehab@...nel.org, shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com, linux-media@...r.kernel.org, imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, hverkuil@...nel.org, nicolas.dufresne@...labora.com, sakari.ailus@...ux.intel.com, tomi.valkeinen@...asonboard.com, jonas@...boo.se, dan.scally+renesas@...asonboard.com, m.szyprowski@...sung.com, mehdi.djait@...ux.intel.com, niklas.soderlund+renesas@...natech.se
Subject: Re: [PATCH v2 3/3] media: imx-mipi-csis: Get number of active lanes via mbus_config

Hi Frank,

Thank you for the review!

Quoting Frank Li (2025-09-03 16:35:16)
> On Wed, Sep 03, 2025 at 11:22:42AM +0100, Isaac Scott wrote:
> > The number of lanes actively used by a MIPI CSI transmitter may differ
> > from that which is defined in device tree. As such, call on
> > v4l2_get_active_data_lanes to check if the driver reports a
> 
> function need (), v4l2_get_active_data_lanes()
> 
> > differing number of lanes to device tree, and use that number of active
> > lanes.
> >
> > If the number of active data lanes is invalid, or the op is not
> > supported, it will use the number of lanes defined in device tree.
> 
> remove "it will" to keep simple.

Thanks, I'll change this in v3.

> 
> Frank

Best wishes,

Isaac

> >
> > Signed-off-by: Isaac Scott <isaac.scott@...asonboard.com>
> > ---
> >  drivers/media/platform/nxp/imx-mipi-csis.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/media/platform/nxp/imx-mipi-csis.c b/drivers/media/platform/nxp/imx-mipi-csis.c
> > index fc89325f2f94..985be511bcd0 100644
> > --- a/drivers/media/platform/nxp/imx-mipi-csis.c
> > +++ b/drivers/media/platform/nxp/imx-mipi-csis.c
> > @@ -967,6 +967,9 @@ static int mipi_csis_s_stream(struct v4l2_subdev *sd, int enable)
> >       format = v4l2_subdev_state_get_format(state, CSIS_PAD_SINK);
> >       csis_fmt = find_csis_format(format->code);
> >
> > +     csis->bus.num_data_lanes = v4l2_get_active_data_lanes(csis->source.pad,
> > +                                                           csis->max_data_lanes);
> > +
> >       ret = mipi_csis_calculate_params(csis, csis_fmt);
> >       if (ret < 0)
> >               goto err_unlock;
> > --
> > 2.43.0
> >