linux-kernel - Re: [PATCH v11 3/4] arm64: dts: qcom: Add HAMOA-IOT-SOM platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3b81ea60-553a-48d8-b6c7-6b55673fe04d@oss.qualcomm.com>
Date: Mon, 15 Sep 2025 17:46:09 +0800
From: Yijie Yang <yijie.yang@....qualcomm.com>
To: Stephan Gerhold <stephan.gerhold@...aro.org>
Cc: Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
 <conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Subject: Re: [PATCH v11 3/4] arm64: dts: qcom: Add HAMOA-IOT-SOM platform



On 2025-09-15 16:52, Stephan Gerhold wrote:
> On Mon, Sep 15, 2025 at 10:12:15AM +0800, Yijie Yang wrote:
>>
>>
>> On 2025-09-12 16:48, Stephan Gerhold wrote:
>>> On Wed, Sep 10, 2025 at 05:02:11PM +0800, Yijie Yang wrote:
>>>> The HAMOA-IOT-SOM is a compact computing module that integrates a System
>>>> on Chip (SoC) — specifically the x1e80100 — along with essential
>>>> components optimized for IoT applications. It is designed to be mounted on
>>>> carrier boards, enabling the development of complete embedded systems.
>>>>
>>>> Make the following peripherals on the SOM enabled:
>>>> - Regulators on the SOM
>>>> - Reserved memory regions
>>>> - PCIe6a and its PHY
>>>> - PCIe4 and its PHY
>>>> - USB0 through USB6 and their PHYs
>>>> - ADSP, CDSP
>>>> - Graphic
>>>> - Video
>>>>
>>>> Written in collaboration with Yingying Tang (PCIe4)
>>>> <quic_yintang@...cinc.com> and Wangao Wang (Video)
>>>> <quic_wangaow@...cinc.com>.
>>>
>>> This looks like you should have Co-developed-by: tags together with
>>> their Signed-off-by: tags.
>>
>> We’ve agreed on this as the preferred method for marking collaboration, as
>> discussed earlier in this thread.
>>
> 
> I can't say I agree with Bjorn there, but ok, he's the maintainer. :-)
> 
>>>
>>>>
>>>> Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
>>>> Signed-off-by: Yijie Yang <yijie.yang@....qualcomm.com>
>>>> ---
>>>>    arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi | 621 ++++++++++++++++++++++++++++
>>>>    1 file changed, 621 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi b/arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi
>>>> new file mode 100644
>>>> index 000000000000..c7c3a167eb6a
>>>> --- /dev/null
>>>> +++ b/arch/arm64/boot/dts/qcom/hamoa-iot-som.dtsi
>>>> @@ -0,0 +1,621 @@
>>>> +// SPDX-License-Identifier: BSD-3-Clause
>>>> +/*
>>>> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
>>>> + */
>>>> +
>>>> +#include "x1e80100.dtsi"
>>>> +#include "x1e80100-pmics.dtsi"
>>>> +#include <dt-bindings/gpio/gpio.h>
>>>> +#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>>>> +
>>>> +/ {
>>>> +	compatible = "hamoa-iot-som", "qcom,x1e80100";
>>>
>>> Undocumented compatible (without "qcom," prefix). I think you can just
>>> drop this?
>>
>> This compatible string was also discussed previously and is the preferred
>> choice. I’ll add the missing 'qcom,' prefix.
>>
> 
> Even compatible = "qcom,hamoa-iot-som", "qcom,x1e80100"; is not
> documented. And it doesn't make much sense to document it either, each
> of the boards using the SoM should have a more specific compatible and
> therefore needs to override this property. I think you can really just
> drop this line.

Patch 1/4 documents this compatible. It’s another requirement that 
SoC/SoM should follow, which Krzysztof pointed out in v2:
https://lore.kernel.org/all/aee74e0f-c957-437d-ab48-3977013c3116@kernel.org/

> 
> Thanks,
> Stephan
> 

-- 
Best Regards,
Yijie