linux-kernel - Re: [PATCH v6 2/3] drm: panel: nt36672a: Add support for novatek nt35596s panel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ad1764a3-12b3-4c30-9b79-313d9c1d37eb@ixit.cz>
Date: Mon, 15 Sep 2025 12:11:49 +0200
From: David Heidelberg <david@...t.cz>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
Cc: Sumit Semwal <sumit.semwal@...aro.org>,
 Neil Armstrong <neil.armstrong@...aro.org>,
 Jessica Zhang <jessica.zhang@....qualcomm.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
 Molly Sophia <mollysophia379@...il.com>,
 Arnaud Ferraris <arnaud.ferraris@...labora.com>
Subject: Re: [PATCH v6 2/3] drm: panel: nt36672a: Add support for novatek
 nt35596s panel

On 15/09/2025 03:29, Dmitry Baryshkov wrote:
> On Sat, Sep 13, 2025 at 09:19:48PM +0200, David Heidelberg via B4 Relay wrote:
>> From: Molly Sophia <mollysophia379@...il.com>
>>
>> Novatek NT35596s is a generic DSI IC that drives command and video mode
>> panels.
>> Currently add support for the LCD panel from JDI connected with this IC,
>> as found on Xiaomi Mi Mix 2S phones.
> 
> Why are you adding it to the existing driver rather than adding a new
> one?

Hello, originally it started as a standalone driver (see v2 patchset), 
but got merged due to similarities.

v2 patchset:
https://www.mail-archive.com/dri-devel@lists.freedesktop.org/msg404290.html

If it's desired, I can switch it back to the standalone driver.

> 
>>
>> Signed-off-by: Molly Sophia <mollysophia379@...il.com>
>> Signed-off-by: Arnaud Ferraris <arnaud.ferraris@...labora.com>
>> Signed-off-by: David Heidelberg <david@...t.cz>
>> ---
>>   drivers/gpu/drm/panel/Kconfig                  |   7 +-
>>   drivers/gpu/drm/panel/panel-novatek-nt36672a.c | 225 ++++++++++++++++++++++++-
>>   2 files changed, 222 insertions(+), 10 deletions(-)
>>
>>   
>>   MODULE_AUTHOR("Sumit Semwal <sumit.semwal@...aro.org>");
>> -MODULE_DESCRIPTION("NOVATEK NT36672A based MIPI-DSI LCD panel driver");
>> +MODULE_AUTHOR("Molly Sophia <mollysophia379@...il.com>");
> 
> ??

What's wrong with it?

David

> 
>> +MODULE_DESCRIPTION("NOVATEK NT36672A/NT35596S based MIPI-DSI LCD panel driver");
>>   MODULE_LICENSE("GPL");
>>
>> -- 
>> 2.51.0
>>
>>
> 

-- 
David Heidelberg