linux-kernel - Re: [PATCH v2 1/4] dt-bindings: media: ti,ds90ub953: Add third cell for GPIO controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250915015309.GA2329507-robh@kernel.org>
Date: Sun, 14 Sep 2025 21:10:08 -0500
From: Rob Herring <robh@...nel.org>
To: Guoniu Zhou <guoniu.zhou@....com>
Cc: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Frank Li <Frank.Li@....com>,
	Vladimir Zapolskiy <vz@...ia.com>, linux-media@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/4] dt-bindings: media: ti,ds90ub953: Add third cell
 for GPIO controller

On Thu, Sep 11, 2025 at 04:44:22PM +0800, Guoniu Zhou wrote:
> Add third cell for GPIO controller to select GPIO output source. 0 to
> select output source from local GPIO data, 1 to select output source
> from remote compatible deserializer GPIO data.
> 
> Signed-off-by: Guoniu Zhou <guoniu.zhou@....com>
> ---
>  Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml | 8 +++++---
>  Documentation/devicetree/bindings/media/i2c/ti,ds90ub960.yaml | 4 ++--
>  2 files changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml
> index 2e129bf573b79e0ca8f25b4ec5fc6ea76c50abd7..de759413a36060d3be6f2c3b67de48ee6e4d29f2 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ti,ds90ub953.yaml
> @@ -19,10 +19,12 @@ properties:
>        - ti,ds90ub971-q1
>  
>    '#gpio-cells':
> -    const: 2
> +    const: 3
>      description:
>        First cell is the GPIO pin number, second cell is the flags. The GPIO pin
>        number must be in range of [0, 3].
> +      Third cell is GPIO output source(0 for local gpio data, 1 for remote
> +      gpio data from remote compatible deserializer).

Changing the cell size is an ABI break unless 3 cells was supported in 
OS before which I don't think it would be given GPIO cell meaning is 
pretty standardized. You could just all a flag to the 2nd cell I think. 
Or if 0-3 are local GPIOs, then make remote ones a different range.

Rob