linux-kernel - Re: [PATCH 0/5] drm/solomon: Code improvements and DRM helper adoption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8c445737-bb23-4026-954b-61b234be9932@suse.de>
Date: Mon, 15 Sep 2025 13:24:47 +0200
From: Thomas Zimmermann <tzimmermann@...e.de>
To: Iker Pedrosa <ikerpedrosam@...il.com>,
 Javier Martinez Canillas <javierm@...hat.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/5] drm/solomon: Code improvements and DRM helper
 adoption

Hi

Am 12.09.25 um 18:42 schrieb Iker Pedrosa:
> This patch series improves the Solomon SSD130x DRM driver by adopting
> existing DRM helpers, improving code clarity, and following kernel
> coding standards.
>
> * Patch #1 moves DRM GEM framebuffer CPU access calls to make critical
>    sections more visible and maintainable.
> * Patch #2 replaces WARN_ON with drm_WARN_ON_ONCE to prevent log spam.
> * Patch #3 adopts drm_crtc_helper_mode_valid_fixed() for mode
>    validation.
> * Patch #4 adopts drm_connector_helper_get_modes_fixed() for mode
>    management.
> * Patch #5 enforces one assignment per line per kernel coding style.
>
> These improvements reduce code duplication by leveraging existing DRM
> infrastructure and enhance code readability without changing
> functionality.
>
> Signed-off-by: Iker Pedrosa <ikerpedrosam@...il.com>

For the series

Reviewed-by: Thomas Zimmermann <tzimmermann@...e.de>

It should also get Javier's reviews before getting merged.

Best regards
Thomas

> ---
> Iker Pedrosa (5):
>        drm/solomon: Move calls to drm_gem_fb_end_cpu*()
>        drm/solomon: Use drm_WARN_ON_ONCE instead of WARN_ON
>        drm/solomon: Simplify mode_valid() using DRM helper
>        drm/solomon: Simplify get_modes() using DRM helper
>        drm/solomon: Enforce one assignment per line
>
>   drivers/gpu/drm/solomon/ssd130x.c | 77 +++++++++++++++------------------------
>   1 file changed, 29 insertions(+), 48 deletions(-)
> ---
> base-commit: c571cb70e1ed43ee543c70151e61a001ab2eefa2
> change-id: 20250912-improve-ssd130x-b45b89ff4693
>
> Best regards,

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)