linux-kernel - Re: [PATCH] init: INITRAMFS_PRESERVE_MTIME should depend on BLK_DEV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aa5d1e137ddab12d1fa6beca4279fd9c90ff58dd.camel@suse.com>
Date: Mon, 15 Sep 2025 13:39:38 +0200
From: Martin Wilck <mwilck@...e.com>
To: Geert Uytterhoeven <geert+renesas@...der.be>, Andrew Morton	
 <akpm@...ux-foundation.org>, David Disseldorp <ddiss@...e.de>, Alexander
 Viro	 <viro@...iv.linux.org.uk>, Christian Brauner <brauner@...nel.org>,
 Jan Kara	 <jack@...e.cz>
Cc: Askar Safin <safinaskar@...il.com>, linux-fsdevel@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] init: INITRAMFS_PRESERVE_MTIME should depend on
 BLK_DEV_INITRD

On Mon, 2025-09-15 at 09:11 +0200, Geert Uytterhoeven wrote:
> INITRAMFS_PRESERVE_MTIME is only used in init/initramfs.c and
> init/initramfs_test.c.  Hence add a dependency on BLK_DEV_INITRD, to
> prevent asking the user about this feature when configuring a kernel
> without initramfs support.
> 
> Fixes: 1274aea127b2e8c9 ("initramfs: add INITRAMFS_PRESERVE_MTIME
> Kconfig option")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

Reviewed-by: Martin  Wilck <mwilck@...e.com>

> ---
>  init/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/init/Kconfig b/init/Kconfig
> index e3eb63eadc8757a1..c0c61206499e6bd5 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -1501,6 +1501,7 @@ config BOOT_CONFIG_EMBED_FILE
>  
>  config INITRAMFS_PRESERVE_MTIME
>  	bool "Preserve cpio archive mtimes in initramfs"
> +	depends on BLK_DEV_INITRD
>  	default y
>  	help
>  	  Each entry in an initramfs cpio archive carries an mtime
> value. When