linux-kernel - Re: [PATCH v1 7/7] regulator: s2mps11: add support for S2MPS16 regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f1944f1f-334a-4194-90a3-946c57528927@sirena.org.uk>
Date: Mon, 15 Sep 2025 12:42:25 +0100
From: Mark Brown <broonie@...nel.org>
To: Ivaylo Ivanov <ivo.ivanov.ivanov1@...il.com>
Cc: Krzysztof Kozlowski <krzk@...nel.org>,
	André Draszik <andre.draszik@...aro.org>,
	Sylwester Nawrocki <s.nawrocki@...sung.com>,
	Chanwoo Choi <cw00.choi@...sung.com>,
	Alim Akhtar <alim.akhtar@...sung.com>,
	Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Lee Jones <lee@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Alexandre Belloni <alexandre.belloni@...tlin.com>,
	linux-samsung-soc@...r.kernel.org, devicetree@...r.kernel.org,
	linux-clk@...r.kernel.org, linux-rtc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 7/7] regulator: s2mps11: add support for S2MPS16
 regulators

On Sun, Sep 14, 2025 at 03:42:27PM +0300, Ivaylo Ivanov wrote:

> +static int s2mps16_set_ramp_delay(struct regulator_dev *rdev, int ramp_delay)
> +{
> +	unsigned int ramp_val, ramp_shift, ramp_reg;
> +	int rdev_id = rdev_get_id(rdev);
> +
> +	switch (rdev_id) {

..

> +		ramp_shift = S2MPS16_BUCK_RAMP_SHIFT4;
> +		break;
> +	default:
> +		return 0;
> +	}

The operation should not be present if it's not supported, and should
error out if mistakenly called on an invalid regulator.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)