linux-kernel - Re: [PATCH v2 11/33] net: use ns_common

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <rdp6afroud2vjvh6mjzbvq25ok2thpps5o2l3ygudrbbjpceln@qadh4ztv7deh>
Date: Mon, 15 Sep 2025 13:50:31 +0200
From: Jan Kara <jack@...e.cz>
To: Christian Brauner <brauner@...nel.org>
Cc: Jan Kara <jack@...e.cz>, Amir Goldstein <amir73il@...il.com>, 
	linux-fsdevel@...r.kernel.org, Josef Bacik <josef@...icpanda.com>, 
	Jeff Layton <jlayton@...nel.org>, Mike Yuan <me@...dnzj.com>, 
	Zbigniew Jędrzejewski-Szmek <zbyszek@...waw.pl>, Lennart Poettering <mzxreary@...inter.de>, 
	Daan De Meyer <daan.j.demeyer@...il.com>, Aleksa Sarai <cyphar@...har.com>, 
	Alexander Viro <viro@...iv.linux.org.uk>, Jens Axboe <axboe@...nel.dk>, Tejun Heo <tj@...nel.org>, 
	Johannes Weiner <hannes@...xchg.org>, Michal Koutný <mkoutny@...e.com>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, 
	Chuck Lever <chuck.lever@...cle.com>, linux-nfs@...r.kernel.org, linux-kselftest@...r.kernel.org, 
	linux-block@...r.kernel.org, linux-kernel@...r.kernel.org, cgroups@...r.kernel.org, 
	netdev@...r.kernel.org
Subject: Re: [PATCH v2 11/33] net: use ns_common_init()

On Mon 15-09-25 13:42:04, Christian Brauner wrote:
> On Mon, Sep 15, 2025 at 01:07:06PM +0200, Jan Kara wrote:
> > On Fri 12-09-25 13:52:34, Christian Brauner wrote:
> > > Don't cargo-cult the same thing over and over.
> > > 
> > > Signed-off-by: Christian Brauner <brauner@...nel.org>
> > 
> > ...
> > 
> > > @@ -559,7 +572,9 @@ struct net *copy_net_ns(unsigned long flags,
> > >  		goto dec_ucounts;
> > >  	}
> > >  
> > > -	preinit_net(net, user_ns);
> > > +	rv = preinit_net(net, user_ns);
> > > +	if (rv < 0)
> > > +		goto dec_ucounts;
> > 
> > Umm, this seems to be leaking 'net' on error exit.
> 
> Sorry about this:

Looks good now. Feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> 
> diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c
> index 5fb7bd8ac45a..466de530c495 100644
> --- a/net/core/net_namespace.c
> +++ b/net/core/net_namespace.c
> @@ -572,12 +572,13 @@ struct net *copy_net_ns(unsigned long flags,
>                 goto dec_ucounts;
>         }
> 
> -       rv = preinit_net(net, user_ns);
> -       if (rv < 0)
> -               goto dec_ucounts;
>         net->ucounts = ucounts;
>         get_user_ns(user_ns);
> 
> +       rv = preinit_net(net, user_ns);
> +       if (rv < 0)
> +               goto put_userns;
> +
>         rv = down_read_killable(&pernet_ops_rwsem);
>         if (rv < 0)
>                 goto put_userns;
> 
> Thanks for noticing! Fixed in-tree.
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR