linux-kernel - Re: [PATCH] initrd: Fix logged Minix/Ext2 block numbers in identify_ramdisk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250915122146.56f66eb2.ddiss@suse.de>
Date: Mon, 15 Sep 2025 12:21:46 +1000
From: David Disseldorp <ddiss@...e.de>
To: Thorsten Blum <thorsten.blum@...ux.dev>
Cc: Alexander Viro <viro@...iv.linux.org.uk>, Christian Brauner
 <brauner@...nel.org>, Jan Kara <jack@...e.cz>,
 linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] initrd: Fix logged Minix/Ext2 block numbers in
 identify_ramdisk_image()

Hi Thorsten,

On Sat, 13 Sep 2025 12:39:54 +0200, Thorsten Blum wrote:

> Both Minix and Ext2 filesystems are located at 'start_block + 1'. Update
> the log messages to report the correct block numbers.

I don't think this change is worthwhile. The offset of the superblock
within the filesystem image is an implementation detail.

> Replace printk(KERN_NOTICE) with pr_notice() to avoid checkpatch
> warnings.
> 
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")

Nothing is being fixed here.