linux-kernel - Re: [PATCH] zorro: remove extra whitespace in macro definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdXpn8VhFL3RF_NEEdK3-VuHuHHZ6PFBcJi+kYCgbnwL8Q@mail.gmail.com>
Date: Mon, 15 Sep 2025 13:54:29 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Dishank Jogi <jogidishank503@...il.com>
Cc: linux-m68k@...ts.linux-m68k.org, linux-kernel@...r.kernel.org, 
	darshanrathod475@...il.com
Subject: Re: [PATCH] zorro: remove extra whitespace in macro definitions

Hi Dishank,

On Mon, 28 Jul 2025 at 09:15, Dishank Jogi <jogidishank503@...il.com> wrote:
> Cleaned up the formatting of MANUF and PRODUCT macro
> definitions in 'drivers/zorro/names.c' by removing extra
> spaces between macro names and their parameters.
>
> No functional changes.
>
> Signed-off-by: Dishank Jogi <jogidishank503@...il.com>

Thanks for your patch!

> --- a/drivers/zorro/names.c
> +++ b/drivers/zorro/names.c
> @@ -36,21 +36,21 @@ struct zorro_manuf_info {
>   * real memory.. Parse the same file multiple times
>   * to get all the info.
>   */
> -#define MANUF( manuf, name )           static char __manufstr_##manuf[] __initdata = name;
> +#define MANUF(manuf, name)             static char __manufstr_##manuf[] __initdata = name;
>  #define ENDMANUF()
> -#define PRODUCT( manuf, prod, name )   static char __prodstr_##manuf##prod[] __initdata = name;
> +#define PRODUCT(manuf, prod, name)     static char __prodstr_##manuf##prod[] __initdata = name;

You missed removing a bogus space.  I will fix that up while applying.

>  #include "devlist.h"
>
>
> -#define MANUF( manuf, name )           static struct zorro_prod_info __prods_##manuf[] __initdata = {
> +#define MANUF(manuf, name)             static struct zorro_prod_info __prods_##manuf[] __initdata = {
>  #define ENDMANUF()                     };
> -#define PRODUCT( manuf, prod, name )   { 0x##prod, 0, __prodstr_##manuf##prod },
> +#define PRODUCT(manuf, prod, name)     { 0x##prod, 0, __prodstr_##manuf##prod },
>  #include "devlist.h"
>
>  static struct zorro_manuf_info __initdata zorro_manuf_list[] = {
> -#define MANUF( manuf, name )           { 0x##manuf, ARRAY_SIZE(__prods_##manuf), __manufstr_##manuf, __prods_##manuf },
> +#define MANUF(manuf, name)             { 0x##manuf, ARRAY_SIZE(__prods_##manuf), __manufstr_##manuf, __prods_##manuf },
>  #define ENDMANUF()
> -#define PRODUCT( manuf, prod, name )
> +#define PRODUCT(manuf, prod, name)
>  #include "devlist.h"
>  };

Reviewed-by: Geert Uytterhoeven <geert@...ux-m68k.org>
i.e. will queue in the m68k tree for v6.18.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds