linux-kernel - Re: [PATCH 2/6] iio: health: afe4403: Use devm_regulator_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4333d98d-3f6c-4c22-8dee-e4349a7b4046@ti.com>
Date: Mon, 15 Sep 2025 07:13:18 -0500
From: Andrew Davis <afd@...com>
To: Jonathan Cameron <jic23@...nel.org>, David Lechner <dlechner@...libre.com>
CC: Nuno Sá <nuno.sa@...log.com>,
        Andy Shevchenko
	<andy@...nel.org>, <linux-iio@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/6] iio: health: afe4403: Use devm_regulator_get_enable()
 helper

On 9/13/25 9:20 AM, Jonathan Cameron wrote:
> On Wed, 13 Aug 2025 18:12:26 -0500
> David Lechner <dlechner@...libre.com> wrote:
> 
>> On 8/13/25 5:58 PM, Andrew Davis wrote:
>>> This takes care of both getting and enabling the regulator in one
>>> function, it also handles the devm action, so remove that. Also
>>> do not disable the regulator on suspend, this will be handled for
>>
>> I didn't know that this worked automatically. What is the mechanism
>> that makes it work? I've seen lots of drivers doing the disable/
>> enable in suspend/resume, so I just always assumed that was how one
>> is supposed to do it.
>>
> Hi Andrew
> 
> This question is still open, so I'll not pick the reset of the series
> up until it's resolved.  I'm going to mark these in patchwork as
> changes requested so will need a v2 now.
> 

Sounds good, I'm still working on tracking down the answer to the
question. I think it involves the regulator suspend path but
will sort it out fully for v2.

Thanks,
Andrew

> 
> Jonathan
> 
>>> us. We now do not need to track the regulator at all, so drop it
>>> from the device struct.
>>>
>>> Signed-off-by: Andrew Davis <afd@...com>
>