linux-kernel - Re: [PATCH] spi: amlogic: Fix error checking on regmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <93a8e900-cca3-43d9-8f5b-c8431e20cec6@amlogic.com>
Date: Mon, 15 Sep 2025 10:29:35 +0800
From: Xianwei Zhao <xianwei.zhao@...ogic.com>
To: Colin Ian King <colin.i.king@...il.com>,
 Liang Yang <liang.yang@...ogic.com>, Feng Chen <feng.chen@...ogic.com>,
 Mark Brown <broonie@...nel.org>, linux-amlogic@...ts.infradead.org,
 linux-spi@...r.kernel.org
Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: amlogic: Fix error checking on regmap_write call


Reviewed-by:Xianwei Zhao <xianwei.zhao@...ogic.com>
On 2025/9/14 04:15, Colin Ian King wrote:
> [You don't often get email from colin.i.king@...il.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> [ EXTERNAL EMAIL ]
> 
> Currently a call to regmap_write is not being error checked because the
> return checke is being performed on the variable ret and this variable
> is not assigned the return value from the regmap_write call. Fix this
> by adding in the missing assignment.
> 
> Fixes: 4670db6f32e9 ("spi: amlogic: add driver for Amlogic SPI Flash Controller")
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>   drivers/spi/spi-amlogic-spifc-a4.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-amlogic-spifc-a4.c b/drivers/spi/spi-amlogic-spifc-a4.c
> index 4ca8e82fdc67..4338d00e56a6 100644
> --- a/drivers/spi/spi-amlogic-spifc-a4.c
> +++ b/drivers/spi/spi-amlogic-spifc-a4.c
> @@ -420,7 +420,7 @@ static int aml_sfc_dma_buffer_setup(struct aml_sfc *sfc, void *databuf,
>                  goto out_map_data;
> 
>          cmd = CMD_DATA_ADDRH(sfc->daddr);
> -       regmap_write(sfc->regmap_base, SFC_CMD, cmd);
> +       ret = regmap_write(sfc->regmap_base, SFC_CMD, cmd);
>          if (ret)
>                  goto out_map_data;
> 
> --
> 2.51.0
>