linux-kernel - Re: [PATCH net v2] net: natsemi: fix `rx_dropped` double accounting on `netif

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <175798920625.572140.10879472998951369666.git-patchwork-notify@kernel.org>
Date: Tue, 16 Sep 2025 02:20:06 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Yeounsu Moon <yyyynoom@...il.com>
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, horms@...nel.org, eric.dumazet@...il.com,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v2] net: natsemi: fix `rx_dropped` double accounting
 on
 `netif_rx()` failure

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Sat, 13 Sep 2025 15:01:36 +0900 you wrote:
> `netif_rx()` already increments `rx_dropped` core stat when it fails.
> The driver was also updating `ndev->stats.rx_dropped` in the same path.
> Since both are reported together via `ip -s -s` command, this resulted
> in drops being counted twice in user-visible stats.
> 
> Keep the driver update on `if (unlikely(!skb))`, but skip it after
> `netif_rx()` errors.
> 
> [...]

Here is the summary with links:
  - [net,v2] net: natsemi: fix `rx_dropped` double accounting on `netif_rx()` failure
    https://git.kernel.org/netdev/net/c/93ab4881a4e2

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html