linux-kernel - Re: [PATCH 0/6] ARM: dts: qcom: msm8960: cleanup and add missing I2C nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5ge4fmciy5khy7axvzapmdv55abouzmr6t5j7irz2glznetr6y@ky6v43cyf6ir>
Date: Tue, 16 Sep 2025 10:24:14 -0500
From: Bjorn Andersson <andersson@...nel.org>
To: Antony Kurniawan Soemardi <linux@...nkusors.com>
Cc: Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Linus Walleij <linus.walleij@...aro.org>, linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, 
	linux-gpio@...r.kernel.org, David Heidelberg <david@...t.cz>, 
	Max Shevchenko <wctrl@...ton.me>, Rudraksha Gupta <guptarud@...il.com>, 
	Shinjo Park <peremen@...il.com>
Subject: Re: [PATCH 0/6] ARM: dts: qcom: msm8960: cleanup and add missing I2C
 nodes

On Sun, Sep 14, 2025 at 06:34:38PM +0000, Antony Kurniawan Soemardi wrote:
> While working on adding support for the Sony Xperia SP (msm8960t), it
> was pointed out [1] that the msm8960 dtsi could use some general
> cleanup and reordering. This series applies those suggestions and also
> fills in missing I2C nodes that are required by several phones based on
> msm8960.
> 
> Changes included:
> 
> 1. Reorders nodes by unit address and sorts properties to comply with
>    the Devicetree style guide. Cosmetic only.
> 2. Inlines qcom-msm8960-pins.dtsi into the main SoC dtsi. Most Qualcomm
>    SoCs embed their TLMM definitions directly, so this removes an
>    uncommon split file pattern. Cosmetic only.
> 3. Adds I2C child nodes for GSBI10 and GSBI12, which are present on
>    MSM8960 and required by devices such as the Sony Xperia SP.
> 4. Adds I2C child nodes for GSBI1 and GSBI8, which are present on
>    MSM8960 and required by devices such as the Casio G'zOne. This work
>    was contributed by Shinjo Park.
> 5. Updates the binding documentation to rename the GPIO controller node
>    from "msmgpio" to "tlmm".
> 5. Renames the GPIO controller node label from "msmgpio" to "tlmm" to
>    match the convention used by other Qualcomm SoCs. Cosmetic only.
> 
> [1] https://lore.kernel.org/all/rcazqdcr747ujkba6z2j2oci27ajkqfi4hydgc2kiavm73y37x@g63jga2fcwmo/
> 
> Thanks,
> 
> ---
> Antony Kurniawan Soemardi (6):
>       ARM: dts: qcom: msm8960: reorder nodes and properties
>       ARM: dts: qcom: msm8960: inline qcom-msm8960-pins.dtsi
>       ARM: dts: qcom: msm8960: add I2C nodes for gsbi10 and gsbi12
>       ARM: dts: qcom: msm8960: add I2C nodes for gsbi1 and gsbi8
>       dt-bindings: pinctrl: qcom: msm8960: rename msmgpio node to tlmm
>       ARM: dts: qcom: msm8960: rename msmgpio node to tlmm
> 
>  .../bindings/pinctrl/qcom,msm8960-pinctrl.yaml     |   4 +-
>  arch/arm/boot/dts/qcom/qcom-msm8960-cdp.dts        |  10 +-
>  arch/arm/boot/dts/qcom/qcom-msm8960-pins.dtsi      |  59 --
>  .../dts/qcom/qcom-msm8960-samsung-expressatt.dts   |  12 +-
>  .../boot/dts/qcom/qcom-msm8960-sony-huashan.dts    |   2 +-
>  arch/arm/boot/dts/qcom/qcom-msm8960.dtsi           | 727 ++++++++++++++-------
>  6 files changed, 491 insertions(+), 323 deletions(-)
> ---
> base-commit: 9e410f58e82ea0c0e865f688d84edad1da7824d2

I unfortunately don't have this commit, and I can't fine a branch where
patch 1 applies cleanly. Can you please rebase this on top of linux-next
and resubmit it?

Regards,
Bjorn

> change-id: 20250831-msm8960-reorder-1849dee3817f
> 
> Best regards,
> --
> Antony Kurniawan Soemardi <linux@...nkusors.com>
>