linux-kernel - Re: [PATCH v2] usb: gadget: zero: add function wakeup support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aMmGPmBdRi7ACxBm@lizhi-Precision-Tower-5810>
Date: Tue, 16 Sep 2025 11:46:06 -0400
From: Frank Li <Frank.li@....com>
To: Xu Yang <xu.yang_2@....com>
Cc: gregkh@...uxfoundation.org, tglx@...utronix.de, mingo@...nel.org,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	imx@...ts.linux.dev, jun.li@....com
Subject: Re: [PATCH v2] usb: gadget: zero: add function wakeup support

On Tue, Sep 16, 2025 at 10:05:44AM +0800, Xu Yang wrote:
> When the device working at enhanced superspeed, it needs to send function
> remote wakeup signal to the host instead of device remote wakeup. Add
> function wakeup support for the purpose.
>
> Signed-off-by: Xu Yang <xu.yang_2@....com>

Reviewed-by: Frank Li <Frank.Li@....com>
>
> ---
> Changes in v2:
>  - fix alignment
> ---
>  drivers/usb/gadget/legacy/zero.c | 27 ++++++++++++++++++---------
>  1 file changed, 18 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/usb/gadget/legacy/zero.c b/drivers/usb/gadget/legacy/zero.c
> index a05785bdeb30..08a21bd0c2ba 100644
> --- a/drivers/usb/gadget/legacy/zero.c
> +++ b/drivers/usb/gadget/legacy/zero.c
> @@ -147,6 +147,12 @@ static struct usb_gadget_strings *dev_strings[] = {
>  	NULL,
>  };
>
> +static struct usb_function *func_lb;
> +static struct usb_function_instance *func_inst_lb;
> +
> +static struct usb_function *func_ss;
> +static struct usb_function_instance *func_inst_ss;
> +
>  /*-------------------------------------------------------------------------*/
>
>  static struct timer_list	autoresume_timer;
> @@ -156,6 +162,7 @@ static void zero_autoresume(struct timer_list *unused)
>  {
>  	struct usb_composite_dev	*cdev = autoresume_cdev;
>  	struct usb_gadget		*g = cdev->gadget;
> +	int				status;
>
>  	/* unconfigured devices can't issue wakeups */
>  	if (!cdev->config)
> @@ -165,10 +172,18 @@ static void zero_autoresume(struct timer_list *unused)
>  	 * more significant than just a timer firing; likely
>  	 * because of some direct user request.
>  	 */
> -	if (g->speed != USB_SPEED_UNKNOWN) {
> -		int status = usb_gadget_wakeup(g);
> -		INFO(cdev, "%s --> %d\n", __func__, status);
> +	if (g->speed == USB_SPEED_UNKNOWN)
> +		return;
> +
> +	if (g->speed >= USB_SPEED_SUPER) {
> +		if (loopdefault)
> +			status = usb_func_wakeup(func_lb);
> +		else
> +			status = usb_func_wakeup(func_ss);
> +	} else {
> +		status = usb_gadget_wakeup(g);
>  	}
> +	INFO(cdev, "%s --> %d\n", __func__, status);
>  }
>
>  static void zero_suspend(struct usb_composite_dev *cdev)
> @@ -206,9 +221,6 @@ static struct usb_configuration loopback_driver = {
>  	/* .iConfiguration = DYNAMIC */
>  };
>
> -static struct usb_function *func_ss;
> -static struct usb_function_instance *func_inst_ss;
> -
>  static int ss_config_setup(struct usb_configuration *c,
>  		const struct usb_ctrlrequest *ctrl)
>  {
> @@ -248,9 +260,6 @@ module_param_named(isoc_maxburst, gzero_options.isoc_maxburst, uint,
>  		S_IRUGO|S_IWUSR);
>  MODULE_PARM_DESC(isoc_maxburst, "0 - 15 (ss only)");
>
> -static struct usb_function *func_lb;
> -static struct usb_function_instance *func_inst_lb;
> -
>  module_param_named(qlen, gzero_options.qlen, uint, S_IRUGO|S_IWUSR);
>  MODULE_PARM_DESC(qlen, "depth of loopback queue");
>
> --
> 2.34.1
>