[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250916115220.4a90c745@batman.local.home>
Date: Tue, 16 Sep 2025 11:52:20 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Kalesh Singh <kaleshsingh@...gle.com>
Cc: akpm@...ux-foundation.org, minchan@...nel.org,
lorenzo.stoakes@...cle.com, david@...hat.com, Liam.Howlett@...cle.com,
rppt@...nel.org, pfalcato@...e.de, kernel-team@...roid.com,
android-mm@...gle.com, Alexander Viro <viro@...iv.linux.org.uk>, Christian
Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>, Kees Cook
<kees@...nel.org>, Vlastimil Babka <vbabka@...e.cz>, Suren Baghdasaryan
<surenb@...gle.com>, Michal Hocko <mhocko@...e.com>, Masami Hiramatsu
<mhiramat@...nel.org>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
Ingo Molnar <mingo@...hat.com>, Peter Zijlstra <peterz@...radead.org>, Juri
Lelli <juri.lelli@...hat.com>, Vincent Guittot
<vincent.guittot@...aro.org>, Dietmar Eggemann <dietmar.eggemann@....com>,
Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>, Valentin
Schneider <vschneid@...hat.com>, Jann Horn <jannh@...gle.com>, Shuah Khan
<shuah@...nel.org>, linux-kernel@...r.kernel.org,
linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
linux-trace-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v2 7/7] mm/tracing: introduce max_vma_count_exceeded
trace event
On Mon, 15 Sep 2025 18:19:53 -0700
Kalesh Singh <kaleshsingh@...gle.com> wrote:
> Hi Steve,
>
> Thanks for the comments and suggestion you are right we can use bpf to
> get the comm. There is nothing special about this trace event. I will
> drop comm in the next revision.
>
> The reason I did the task_struct parameter (current): I believe there
> is a limitation that we must specify at least 1 parameter to the
> TRACE_EVENT() PROTO and ARGS macros.
OK, then this is another issue. We don't want tracepoint "markers".
Each tracepoint can take up to 5K in memory due to the code it
generates and the meta data to control it.
For something like that, we highly recommend dynamic probes (fprobes,
kprobes, etc).
The only purpose of a static tracepoint is to get data within a
function that is too difficult to get via a probe. It should never be
used as a trigger where its purpose is "we hit this path".
-- Steve
Powered by blists - more mailing lists