| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <aMmSpu/TWOmpHJ60@lizhi-Precision-Tower-5810>
Date: Tue, 16 Sep 2025 12:39:02 -0400
From: Frank Li <Frank.li@....com>
To: Ioana Ciornei <ioana.ciornei@....com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>,
Linus Walleij <linus.walleij@...aro.org>,
Bartosz Golaszewski <brgl@...ev.pl>,
Shawn Guo <shawnguo@...nel.org>, Michael Walle <mwalle@...nel.org>,
Lee Jones <lee@...nel.org>, devicetree@...r.kernel.org,
linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 5/9] drivers: gpio: add QIXIS FPGA GPIO controller
On Mon, Sep 15, 2025 at 03:23:50PM +0300, Ioana Ciornei wrote:
> Add support for the GPIO controller found on some QIXIS FPGAs in
> Layerscape boards such as LX2160ARDB and LS1046AQDS. This driver is
> using gpio-regmap.
>
> A GPIO controller has a maximum of 8 lines (all found in the same
> register). Even within the same controller, the GPIO lines' direction is
> fixed, which mean that both input and output lines are found in the same
> register. This is why the driver also passed to gpio-regmap the newly
> added .fixed_direction_output bitmap to represent the true direction of
> the lines.
>
> Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>
> ---
> Changes in v2:
> - Use the newly added .fixed_direction_output bitmap representing
> the fixed direction of the GPIO lines.
>
> drivers/gpio/Kconfig | 9 +++
> drivers/gpio/Makefile | 1 +
> drivers/gpio/gpio-qixis-fpga.c | 123 +++++++++++++++++++++++++++++++++
> 3 files changed, 133 insertions(+)
> create mode 100644 drivers/gpio/gpio-qixis-fpga.c
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 886bef9106da..4ca5890007ff 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -1951,6 +1951,15 @@ config GPIO_LATCH
> Say yes here to enable a driver for GPIO multiplexers based on latches
> connected to other GPIOs.
>
> +config GPIO_QIXIS_FPGA
> + tristate "NXP QIXIS FPGA GPIO support"
> + depends on MFD_SIMPLE_MFD_I2C || COMPILE_TEST
> + select GPIO_REGMAP
> + help
> + This enables support for the GPIOs found in the QIXIS FPGA which is
> + integrated on some NXP Layerscape boards such as LX2160ARDB and
> + LS1046AQDS.
> +
> config GPIO_MOCKUP
> tristate "GPIO Testing Driver (DEPRECATED)"
> select IRQ_SIM
> diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile
> index 379f55e9ed1e..373b1f169558 100644
> --- a/drivers/gpio/Makefile
> +++ b/drivers/gpio/Makefile
> @@ -144,6 +144,7 @@ obj-$(CONFIG_GPIO_PL061) += gpio-pl061.o
> obj-$(CONFIG_GPIO_PMIC_EIC_SPRD) += gpio-pmic-eic-sprd.o
> obj-$(CONFIG_GPIO_POLARFIRE_SOC) += gpio-mpfs.o
> obj-$(CONFIG_GPIO_PXA) += gpio-pxa.o
> +obj-$(CONFIG_GPIO_QIXIS_FPGA) += gpio-qixis-fpga.o
> obj-$(CONFIG_GPIO_RASPBERRYPI_EXP) += gpio-raspberrypi-exp.o
> obj-$(CONFIG_GPIO_RC5T583) += gpio-rc5t583.o
> obj-$(CONFIG_GPIO_RCAR) += gpio-rcar.o
> diff --git a/drivers/gpio/gpio-qixis-fpga.c b/drivers/gpio/gpio-qixis-fpga.c
> new file mode 100644
> index 000000000000..23219a634f73
> --- /dev/null
> +++ b/drivers/gpio/gpio-qixis-fpga.c
> @@ -0,0 +1,123 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Layerscape GPIO QIXIS FPGA driver
> + *
> + * Copyright 2025 NXP
> + */
> +
> +#include <linux/device.h>
> +#include <linux/gpio/driver.h>
> +#include <linux/gpio/regmap.h>
> +#include <linux/kernel.h>
> +#include <linux/mod_devicetable.h>
> +#include <linux/module.h>
> +#include <linux/platform_device.h>
> +#include <linux/regmap.h>
> +
> +enum qixis_cpld_gpio_type {
> + LX2160ARDB_GPIO_SFP = 0,
> + LS1046AQDS_GPIO_STAT_PRES2,
> +};
needn't type at all.
> +
> +struct qixis_cpld_gpio_config {
> + enum qixis_cpld_gpio_type type;
> + u64 output_lines;
> +};
> +
> +static struct qixis_cpld_gpio_config lx2160ardb_sfp_cfg = {
> + .type = LX2160ARDB_GPIO_SFP,
> + .output_lines = BIT(0),
> +};
> +
> +static struct qixis_cpld_gpio_config ls1046aqds_stat_pres2_cfg = {
> + .type = LS1046AQDS_GPIO_STAT_PRES2,
> + .output_lines = 0x0,
> +};
> +
> +static const struct regmap_config regmap_config_8r_8v = {
> + .reg_bits = 8,
> + .val_bits = 8,
> +};
> +
> +static int qixis_cpld_gpio_probe(struct platform_device *pdev)
> +{
> + const struct qixis_cpld_gpio_config *cfg;
> + struct gpio_regmap_config config = {0};
> + struct regmap *regmap;
> + void __iomem *reg;
> + u32 base;
> + int ret;
> +
> + if (!pdev->dev.parent)
> + return -ENODEV;
> +
> + cfg = device_get_match_data(&pdev->dev);
> + if (!cfg)
> + return -ENODEV;
Needn't this check.
> +
> + ret = device_property_read_u32(&pdev->dev, "reg", &base);
> + if (ret)
> + return ret;
> +
> + regmap = dev_get_regmap(pdev->dev.parent, NULL);
> + if (!regmap) {
> + /* In case there is no regmap configured by the parent device,
> + * create our own.
> + */
/* Use MMIO space */
> + reg = devm_platform_ioremap_resource(pdev, 0);
> + if (!reg)
> + return -ENODEV;
> +
> + regmap = devm_regmap_init_mmio(&pdev->dev, reg, ®map_config_8r_8v);
> + if (!regmap)
> + return -ENODEV;
> +
> + /* In this case, the offset of our register is 0 inside the
> + * regmap area that we just created.
> + */
> + base = 0;
> + }
> +
> + config.drvdata = (void *)cfg;
> + config.regmap = regmap;
> + config.parent = &pdev->dev;
> + config.ngpio_per_reg = 8;
> + config.ngpio = 8;
> + config.fixed_direction_output = bitmap_alloc(8, GFP_KERNEL);
> + if (!config.fixed_direction_output)
> + return -ENOMEM;
> + bitmap_from_u64(config.fixed_direction_output, cfg->output_lines);
> +
> + switch (cfg->type) {
> + case LX2160ARDB_GPIO_SFP:
> + case LS1046AQDS_GPIO_STAT_PRES2:
> + config.reg_dat_base = GPIO_REGMAP_ADDR(base);
> + config.reg_set_base = GPIO_REGMAP_ADDR(base);
only two compatibles string in qixis_cpld_gpio_of_match. so it can set
unconditional.
Frank
> + break;
> + }
> +
> + return PTR_ERR_OR_ZERO(devm_gpio_regmap_register(&pdev->dev, &config));
> +}
> +
> +static const struct of_device_id qixis_cpld_gpio_of_match[] = {
> + {
> + .compatible = "fsl,lx2160ardb-fpga-gpio-sfp",
> + .data = &lx2160ardb_sfp_cfg,
> + },
> + {
> + .compatible = "fsl,ls1046aqds-fpga-gpio-stat-pres2",
> + .data = &ls1046aqds_stat_pres2_cfg,
> + },
> +
> + {}
> +};
> +MODULE_DEVICE_TABLE(of, qixis_cpld_gpio_of_match);
> +
> +static struct platform_driver qixis_cpld_gpio_driver = {
> + .probe = qixis_cpld_gpio_probe,
> + .driver = {
> + .name = "gpio-qixis-cpld",
> + .of_match_table = qixis_cpld_gpio_of_match,
> + },
> +};
> +module_platform_driver(qixis_cpld_gpio_driver);
> --
> 2.25.1
>
Powered by blists - more mailing lists