| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAGudoHGxxf_vXB-J8SWwaq6MFdK-+H=-q1+tx4pDNT8mTgHYug@mail.gmail.com>
Date: Tue, 16 Sep 2025 19:38:30 +0200
From: Mateusz Guzik <mjguzik@...il.com>
To: Viacheslav Dubeyko <Slava.Dubeyko@....com>
Cc: "brauner@...nel.org" <brauner@...nel.org>, "jack@...e.cz" <jack@...e.cz>,
"linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>,
"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
"ceph-devel@...r.kernel.org" <ceph-devel@...r.kernel.org>,
"linux-unionfs@...r.kernel.org" <linux-unionfs@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-btrfs@...r.kernel.org" <linux-btrfs@...r.kernel.org>, "kernel-team@...com" <kernel-team@...com>,
"josef@...icpanda.com" <josef@...icpanda.com>, "viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>,
"amir73il@...il.com" <amir73il@...il.com>,
"linux-xfs@...r.kernel.org" <linux-xfs@...r.kernel.org>
Subject: Re: [PATCH v4 10/12] ceph: use the new ->i_state accessors
On Tue, Sep 16, 2025 at 7:36 PM Viacheslav Dubeyko
<Slava.Dubeyko@....com> wrote:
>
> On Tue, 2025-09-16 at 15:58 +0200, Mateusz Guzik wrote:
> > Change generated with coccinelle and fixed up by hand as appropriate.
> >
> > Signed-off-by: Mateusz Guzik <mjguzik@...il.com>
> > ---
> > fs/ceph/cache.c | 2 +-
> > fs/ceph/crypto.c | 4 ++--
> > fs/ceph/file.c | 4 ++--
> > fs/ceph/inode.c | 28 ++++++++++++++--------------
> > 4 files changed, 19 insertions(+), 19 deletions(-)
> >
>
> Looks good. I simply started to guess. Do we need a method something like this?
>
> bool inode_is_new(struct inode *inode)
> {
> return inode_state_read_once(inode) & I_NEW;
> }
>
Helpers of the sort might show up later after the flag situation gets
sorted out, for now it's baby steps.
> Reviewed-by: Viacheslav Dubeyko <Slava.Dubeyko@....com>
>
> Thanks,
> Slava.
>
> > diff --git a/fs/ceph/cache.c b/fs/ceph/cache.c
> > index 930fbd54d2c8..f678bab189d8 100644
> > --- a/fs/ceph/cache.c
> > +++ b/fs/ceph/cache.c
> > @@ -26,7 +26,7 @@ void ceph_fscache_register_inode_cookie(struct inode *inode)
> > return;
> >
> > /* Only new inodes! */
> > - if (!(inode->i_state & I_NEW))
> > + if (!(inode_state_read_once(inode) & I_NEW))
> > return;
> >
> > WARN_ON_ONCE(ci->netfs.cache);
> > diff --git a/fs/ceph/crypto.c b/fs/ceph/crypto.c
> > index 7026e794813c..928746b92512 100644
> > --- a/fs/ceph/crypto.c
> > +++ b/fs/ceph/crypto.c
> > @@ -329,7 +329,7 @@ int ceph_encode_encrypted_dname(struct inode *parent, char *buf, int elen)
> > out:
> > kfree(cryptbuf);
> > if (dir != parent) {
> > - if ((dir->i_state & I_NEW))
> > + if ((inode_state_read_once(dir) & I_NEW))
> > discard_new_inode(dir);
> > else
> > iput(dir);
> > @@ -438,7 +438,7 @@ int ceph_fname_to_usr(const struct ceph_fname *fname, struct fscrypt_str *tname,
> > fscrypt_fname_free_buffer(&_tname);
> > out_inode:
> > if (dir != fname->dir) {
> > - if ((dir->i_state & I_NEW))
> > + if ((inode_state_read_once(dir) & I_NEW))
> > discard_new_inode(dir);
> > else
> > iput(dir);
> > diff --git a/fs/ceph/file.c b/fs/ceph/file.c
> > index c02f100f8552..59f2be41c9aa 100644
> > --- a/fs/ceph/file.c
> > +++ b/fs/ceph/file.c
> > @@ -744,7 +744,7 @@ static int ceph_finish_async_create(struct inode *dir, struct inode *inode,
> > vino.ino, ceph_ino(dir), dentry->d_name.name);
> > ceph_dir_clear_ordered(dir);
> > ceph_init_inode_acls(inode, as_ctx);
> > - if (inode->i_state & I_NEW) {
> > + if (inode_state_read_once(inode) & I_NEW) {
> > /*
> > * If it's not I_NEW, then someone created this before
> > * we got here. Assume the server is aware of it at
> > @@ -907,7 +907,7 @@ int ceph_atomic_open(struct inode *dir, struct dentry *dentry,
> > new_inode = NULL;
> > goto out_req;
> > }
> > - WARN_ON_ONCE(!(new_inode->i_state & I_NEW));
> > + WARN_ON_ONCE(!(inode_state_read_once(new_inode) & I_NEW));
> >
> > spin_lock(&dentry->d_lock);
> > di->flags |= CEPH_DENTRY_ASYNC_CREATE;
> > diff --git a/fs/ceph/inode.c b/fs/ceph/inode.c
> > index 480cb3a1d639..6786ec955a87 100644
> > --- a/fs/ceph/inode.c
> > +++ b/fs/ceph/inode.c
> > @@ -86,7 +86,7 @@ struct inode *ceph_new_inode(struct inode *dir, struct dentry *dentry,
> > goto out_err;
> > }
> >
> > - inode->i_state = 0;
> > + inode_state_set_raw(inode, 0);
> > inode->i_mode = *mode;
> >
> > err = ceph_security_init_secctx(dentry, *mode, as_ctx);
> > @@ -155,7 +155,7 @@ struct inode *ceph_get_inode(struct super_block *sb, struct ceph_vino vino,
> >
> > doutc(cl, "on %llx=%llx.%llx got %p new %d\n",
> > ceph_present_inode(inode), ceph_vinop(inode), inode,
> > - !!(inode->i_state & I_NEW));
> > + !!(inode_state_read_once(inode) & I_NEW));
> > return inode;
> > }
> >
> > @@ -182,7 +182,7 @@ struct inode *ceph_get_snapdir(struct inode *parent)
> > goto err;
> > }
> >
> > - if (!(inode->i_state & I_NEW) && !S_ISDIR(inode->i_mode)) {
> > + if (!(inode_state_read_once(inode) & I_NEW) && !S_ISDIR(inode->i_mode)) {
> > pr_warn_once_client(cl, "bad snapdir inode type (mode=0%o)\n",
> > inode->i_mode);
> > goto err;
> > @@ -215,7 +215,7 @@ struct inode *ceph_get_snapdir(struct inode *parent)
> > }
> > }
> > #endif
> > - if (inode->i_state & I_NEW) {
> > + if (inode_state_read_once(inode) & I_NEW) {
> > inode->i_op = &ceph_snapdir_iops;
> > inode->i_fop = &ceph_snapdir_fops;
> > ci->i_snap_caps = CEPH_CAP_PIN; /* so we can open */
> > @@ -224,7 +224,7 @@ struct inode *ceph_get_snapdir(struct inode *parent)
> >
> > return inode;
> > err:
> > - if ((inode->i_state & I_NEW))
> > + if ((inode_state_read_once(inode) & I_NEW))
> > discard_new_inode(inode);
> > else
> > iput(inode);
> > @@ -698,7 +698,7 @@ void ceph_evict_inode(struct inode *inode)
> >
> > netfs_wait_for_outstanding_io(inode);
> > truncate_inode_pages_final(&inode->i_data);
> > - if (inode->i_state & I_PINNING_NETFS_WB)
> > + if (inode_state_read_once(inode) & I_PINNING_NETFS_WB)
> > ceph_fscache_unuse_cookie(inode, true);
> > clear_inode(inode);
> >
> > @@ -967,7 +967,7 @@ int ceph_fill_inode(struct inode *inode, struct page *locked_page,
> > le64_to_cpu(info->version), ci->i_version);
> >
> > /* Once I_NEW is cleared, we can't change type or dev numbers */
> > - if (inode->i_state & I_NEW) {
> > + if (inode_state_read_once(inode) & I_NEW) {
> > inode->i_mode = mode;
> > } else {
> > if (inode_wrong_type(inode, mode)) {
> > @@ -1044,7 +1044,7 @@ int ceph_fill_inode(struct inode *inode, struct page *locked_page,
> >
> > #ifdef CONFIG_FS_ENCRYPTION
> > if (iinfo->fscrypt_auth_len &&
> > - ((inode->i_state & I_NEW) || (ci->fscrypt_auth_len == 0))) {
> > + ((inode_state_read_once(inode) & I_NEW) || (ci->fscrypt_auth_len == 0))) {
> > kfree(ci->fscrypt_auth);
> > ci->fscrypt_auth_len = iinfo->fscrypt_auth_len;
> > ci->fscrypt_auth = iinfo->fscrypt_auth;
> > @@ -1638,13 +1638,13 @@ int ceph_fill_trace(struct super_block *sb, struct ceph_mds_request *req)
> > pr_err_client(cl, "badness %p %llx.%llx\n", in,
> > ceph_vinop(in));
> > req->r_target_inode = NULL;
> > - if (in->i_state & I_NEW)
> > + if (inode_state_read_once(in) & I_NEW)
> > discard_new_inode(in);
> > else
> > iput(in);
> > goto done;
> > }
> > - if (in->i_state & I_NEW)
> > + if (inode_state_read_once(in) & I_NEW)
> > unlock_new_inode(in);
> > }
> >
> > @@ -1830,11 +1830,11 @@ static int readdir_prepopulate_inodes_only(struct ceph_mds_request *req,
> > pr_err_client(cl, "inode badness on %p got %d\n", in,
> > rc);
> > err = rc;
> > - if (in->i_state & I_NEW) {
> > + if (inode_state_read_once(in) & I_NEW) {
> > ihold(in);
> > discard_new_inode(in);
> > }
> > - } else if (in->i_state & I_NEW) {
> > + } else if (inode_state_read_once(in) & I_NEW) {
> > unlock_new_inode(in);
> > }
> >
> > @@ -2046,7 +2046,7 @@ int ceph_readdir_prepopulate(struct ceph_mds_request *req,
> > pr_err_client(cl, "badness on %p %llx.%llx\n", in,
> > ceph_vinop(in));
> > if (d_really_is_negative(dn)) {
> > - if (in->i_state & I_NEW) {
> > + if (inode_state_read_once(in) & I_NEW) {
> > ihold(in);
> > discard_new_inode(in);
> > }
> > @@ -2056,7 +2056,7 @@ int ceph_readdir_prepopulate(struct ceph_mds_request *req,
> > err = ret;
> > goto next_item;
> > }
> > - if (in->i_state & I_NEW)
> > + if (inode_state_read_once(in) & I_NEW)
> > unlock_new_inode(in);
> >
> > if (d_really_is_negative(dn)) {
Powered by blists - more mailing lists