linux-kernel - Re: [PATCH v6 1/2] kasan: introduce ARCH_DEFER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250915203653.c17d501a5f4b68936a0e3ea9@linux-foundation.org>
Date: Mon, 15 Sep 2025 20:36:53 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Sabyrzhan Tasbolatov <snovitoll@...il.com>
Cc: Andrey Konovalov <andreyknvl@...il.com>, ryabinin.a.a@...il.com,
 christophe.leroy@...roup.eu, bhe@...hat.com, hca@...ux.ibm.com,
 zhangqing@...ngson.cn, chenhuacai@...ngson.cn, davidgow@...gle.com,
 glider@...gle.com, dvyukov@...gle.com, alexghiti@...osinc.com,
 alex@...ti.fr, agordeev@...ux.ibm.com, vincenzo.frascino@....com,
 elver@...gle.com, kasan-dev@...glegroups.com,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 loongarch@...ts.linux.dev, linuxppc-dev@...ts.ozlabs.org,
 linux-riscv@...ts.infradead.org, linux-s390@...r.kernel.org,
 linux-um@...ts.infradead.org, linux-mm@...ck.org
Subject: Re: [PATCH v6 1/2] kasan: introduce ARCH_DEFER_KASAN and unify
 static key across modes

On Mon, 15 Sep 2025 09:30:03 +0500 Sabyrzhan Tasbolatov <snovitoll@...il.com> wrote:

> On Wed, Sep 3, 2025 at 6:01 PM Andrey Konovalov <andreyknvl@...il.com> wrote:
>

[400+ lines removed - people, please have mercy]

>
> > > @@ -246,7 +255,7 @@ static inline void poison_slab_object(struct kmem_cache *cache, void *object,
> > >  bool __kasan_slab_pre_free(struct kmem_cache *cache, void *object,
> > >                                 unsigned long ip)
> > >  {
> > > -       if (!kasan_arch_is_ready() || is_kfence_address(object))
> > > +       if (is_kfence_address(object))
> > >                 return false;
> >
> > Why is the check removed here and in some other places below? This
> > need to be explained in the commit message.
> 
> kasan_arch_is_ready which was unified with kasan_enabled, was removed
> here because
> __kasan_slab_pre_free is called from include/linux/kasan.h [1] where
> there's already kasan_enabled() check.
> 
> [1] https://elixir.bootlin.com/linux/v6.16.7/source/include/linux/kasan.h#L198
> 
> Please let me know if v7 is required with the change in the git commit
> message only.

Neither works - please send along the appropriate paragraph and I'll
paste it in, can't get easier than that.

> >
>
> [another ~250 lines snipped]
>