linux-kernel - Re: [PATCH v3 1/3] ACPI: processor: Remove unused empty function definition for processor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0iwRzbQAFmTEkq=rMeC_hjr9DAHEGbtBfgL8AU6M5PPqg@mail.gmail.com>
Date: Tue, 16 Sep 2025 22:22:05 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Huisong Li <lihuisong@...wei.com>
Cc: rafael@...nel.org, lenb@...nel.org, linux-acpi@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linuxarm@...wei.com, 
	jonathan.cameron@...wei.com, zhanjie9@...ilicon.com, zhenglifeng1@...wei.com, 
	yubowen8@...wei.com
Subject: Re: [PATCH v3 1/3] ACPI: processor: Remove unused empty function
 definition for processor_idle.c

On Thu, Sep 11, 2025 at 1:24 PM Huisong Li <lihuisong@...wei.com> wrote:
>
> If CONFIG_ACPI_PROCESSOR=n and CONFIG_ACPI_PROCESSOR_IDLE=n,
> we may encounter some warnings about function defined but not
> used. All external functions of processor_idle.c are just used
> in processor_driver.c. And if CONFIG_ACPI_PROCESSOR is selected
> and CONFIG_ACPI_PROCESSOR_IDLE also be selected automatically.
> So remove these empty function definitions.
>
> Signed-off-by: Huisong Li <lihuisong@...wei.com>
> ---
>  include/acpi/processor.h | 20 --------------------
>  1 file changed, 20 deletions(-)
>
> diff --git a/include/acpi/processor.h b/include/acpi/processor.h
> index ff864c1cee3a..2976a6d0c54f 100644
> --- a/include/acpi/processor.h
> +++ b/include/acpi/processor.h
> @@ -425,26 +425,6 @@ int acpi_processor_power_state_has_changed(struct acpi_processor *pr);
>  int acpi_processor_hotplug(struct acpi_processor *pr);
>  void acpi_processor_register_idle_driver(void);
>  void acpi_processor_unregister_idle_driver(void);
> -#else
> -static inline int acpi_processor_power_init(struct acpi_processor *pr)
> -{
> -       return -ENODEV;
> -}
> -
> -static inline int acpi_processor_power_exit(struct acpi_processor *pr)
> -{
> -       return -ENODEV;
> -}
> -
> -static inline int acpi_processor_power_state_has_changed(struct acpi_processor *pr)
> -{
> -       return -ENODEV;
> -}
> -
> -static inline int acpi_processor_hotplug(struct acpi_processor *pr)
> -{
> -       return -ENODEV;
> -}
>  #endif /* CONFIG_ACPI_PROCESSOR_IDLE */
>
>  /* in processor_thermal.c */
> --

Applied as 6.18 material under adjusted subject and with a new
changelog, thanks!