lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <175805162005.266431.9349963404486851031.b4-ty@kernel.org>
Date: Tue, 16 Sep 2025 22:13:48 +0100
From: Will Deacon <will@...nel.org>
To: Catalin Marinas <catalin.marinas@....com>,
	Marc Zyngier <maz@...nel.org>,
	Sam Edwards <cfsworks@...il.com>
Cc: kernel-team@...roid.com,
	Will Deacon <will@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Anshuman Khandual <anshuman.khandual@....com>,
	Ard Biesheuvel <ardb@...nel.org>,
	Ryan Roberts <ryan.roberts@....com>,
	Baruch Siach <baruch@...s.co.il>,
	Kevin Brodsky <kevin.brodsky@....com>,
	Joey Gouly <joey.gouly@....com>,
	linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org,
	Sam Edwards <CFSworks@...il.com>
Subject: Re: [PATCH v2 0/3] Type correctness cleanup for ARM64 MMU initialization

On Wed, 03 Sep 2025 17:52:06 -0700, Sam Edwards wrote:
> This is a small series of type correctness and readability improvements for
> ARM64's MMU initialization code. When I first encountered this code, the heavy
> use of u64 to represent both virtual and physical addresses made it difficult
> to understand where the demarcations were. I made most of the changes in this
> series while troubleshooting a different problem (fixed in a separate patch) to
> make that boundary a little clearer. I am submitting it now in the hopes that
> this will improve maintainability and readability for others.
> 
> [...]

I must confess, I don't personally see a huge amount of value from these
changes. However, I've probably just got used to things and so if this
would've helped you understand the code when you first came across it
recently then I think it's worth having.

Applied to arm64 (for-next/mm), thanks!

[1/3] arm64: mm: Cast start/end markers to char *, not u64
      https://git.kernel.org/arm64/c/030b3ffbdac7
[2/3] arm64: mm: Make map_fdt() return mapped pointer
      https://git.kernel.org/arm64/c/c56aa9a67a08
[3/3] arm64: mm: Represent physical memory with phys_addr_t and resource_size_t
      https://git.kernel.org/arm64/c/b868fff5b10b

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ